Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker control NAN bug - Safari browser #2095

Closed
badcat opened this issue Jul 27, 2017 · 4 comments
Closed

Datepicker control NAN bug - Safari browser #2095

badcat opened this issue Jul 27, 2017 · 4 comments
Labels
Milestone

Comments

@badcat
Copy link

@badcat badcat commented Jul 27, 2017

The Countdown element resets itself to Zeros via the not a number NaN-aN-aN aN:aN in Safari 10.1.2 every time it is reselected for editing style. Each time I need to reset the date which the Datepicker dropdown looks like this by default.

screen shot 2017-07-27 at 5 34 30 pm

This is using Elementor Version 1.5.5 (and even with 1.6.0 rc3) and Pro Version 1.5.8

Seems OK in Chrome and FF. thanks.

@arielk arielk changed the title Countdown Datepicker NAN bug Countdown Datepicker NAN bug on Safari browser Jul 28, 2017
@arielk arielk changed the title Countdown Datepicker NAN bug on Safari browser Countdown Datepicker NAN bug - Safari browser Jul 28, 2017
@arielk arielk added the bug label Jul 28, 2017
@arielk arielk changed the title Countdown Datepicker NAN bug - Safari browser Datepicker control NAN bug - Safari browser Aug 28, 2017
@chayaneng
Copy link

@chayaneng chayaneng commented Aug 28, 2017

I am getting this problem on every browser. hat Would be the solution?

@phpbits
Copy link

@phpbits phpbits commented Sep 13, 2017

Any solution? I'm getting the same issue. Thanks!

@phpbits
Copy link

@phpbits phpbits commented Sep 14, 2017

Found it! Digging on Elementor Pro just found out that you'll be needing to change the default date() format and it will work perfectly 👍

$element->add_control( 'widget_options', [ 'label' => __( 'Sample DatePicker', 'widget-options' ), 'type' => Elementor\Controls_Manager::DATE_TIME, 'default' => date( 'Y-m-d H:i' ), 'description' => __( 'Checkout Widget Options for WordPress', 'widget-options' ), ] );

@bainternet bainternet added this to the 1.9.0 milestone Dec 25, 2017
@bainternet
Copy link
Collaborator

@bainternet bainternet commented Dec 25, 2017

Should be fixed in next version.

related PR: #3006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants