Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Inline Editing #2776

Closed
JoelEadeDesign opened this issue Nov 19, 2017 · 9 comments

Comments

Projects
None yet
5 participants
@JoelEadeDesign
Copy link

commented Nov 19, 2017

Heyo!

Is there a function to disable Inline Editing?

Call me old-fashioned but I prefer the "old" way of having content editing in the left hand editing pane, and being able to click anywhere in the element to drag it around rather than having to click and drag on the edit (pencil) icon.

I've also found the text selection buggy as well. When I select some text to create a link it will deselect the text and add a paragraph to the bottom of the text element (see
elementor_inline_editing_bug

Cheers!

@bainternet

This comment has been minimized.

Copy link
Collaborator

commented Nov 19, 2017

@JoelEadeDesign

As you know you can still do your editing form the left pane, just as you normally would.

as for disabling it... we are about to add some game-changing features to the inline editing for you just might want to keep it.

As for the buggy selection, we'll fix that, so thanks for reporting.

@bainternet bainternet added the bug label Nov 19, 2017

@JoelEadeDesign

This comment has been minimized.

Copy link
Author

commented Nov 19, 2017

"Game-changing" sounds intriguing. I'll stick with it then ;)

Thanks for looking at the bug!

@black-eye

This comment has been minimized.

Copy link

commented Nov 19, 2017

I'm experiencing the same problem with the extra paragraph, even when not selecting the text, just simple clicking into the widget does the same (d)effect.

And when there are more paragraphs in the widget, the extra space is added after each one, not only in the end. When I leave the widget, the normal setting is back and correct.

All this happened just after the update to WP 4.9.

@bainternet

This comment has been minimized.

Copy link
Collaborator

commented Nov 20, 2017

@black-eye
@JoelEadeDesign

thanks, can you confirm its only at the first click?

@bainternet bainternet added the question label Nov 20, 2017

@JoelEadeDesign

This comment has been minimized.

Copy link
Author

commented Nov 20, 2017

Yep, it’s the first click when focussing on an element. Focussing elsewhere then returning to the element will again create a new paragraph and move the cursor to the bottom of the element.

Cheers!

@buzanman

This comment has been minimized.

Copy link

commented Nov 20, 2017

I can confirm this as well it only seems to effect the text editor widget for me on focus selection. The cursor creates a double space and starts in the centre of of the widget. (See screen shot for reference).
screen shot 2017-11-20 at 10 53 35

@reachdigitalaus

This comment has been minimized.

Copy link

commented Nov 22, 2017

I'm also having issues, with inline editing, if you go an edit text, hit enter and the backspace I produce with font sizes . Also, the heading widget, if hit enter it produces empty divs. To test further I did a clean install for WP 4.9 and only have Twenty Seventeen theme installed and only Elementor as a plugin. Hopefully, this video can explain what I mean better.

https://drive.google.com/file/d/14o74_SfPfqxsf9eNhLhubhM_T35-tIwM/view?usp=sharing

Another thing is if you simply go back to WP editor the spans get removed, if you then go back to elemetor the spans come back.

@black-eye

This comment has been minimized.

@bainternet

This comment has been minimized.

Copy link
Collaborator

commented Nov 23, 2017

@black-eye, @buzanman
Yes, it's the same issue we see working on a fix.

@reachdigitalaus what browser are you using???

@JoelEadeDesign
The selection is not an issue as far as we can see because you tried to select before you activated the "Inline Editor". The Inline Editor Is activated on the first click so the correct flow should be :

  1. click to activate Inline Editor.
  2. select your desired text.

We'll update when it's fixed.

@KingYes KingYes closed this in 24c3f0d Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.