Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swiper carouse version up to 4? #4170

Closed
pulla opened this issue Apr 19, 2018 · 5 comments

Comments

Projects
None yet
7 participants
@pulla
Copy link

commented Apr 19, 2018

Hello,

Thank you for the great plugin and love your work.

I have found you are using swiper 3.4.2. But there is already Swiper 4.2.2.
Is there any plan to upgrade?
Because I was going to create a carousel widget with 4.2.2 and it might be conflict with yours.

one more question, is there any reason to use 2 slider js? you are using "slick slider" and "swiper" as well.
It doesn't much different from my poor knowledge. ;) and not sure why you are using 2 sliders. Any reason?

Thank you again,

@anandau

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2018

@arielk
I am also facing issues with outdated swiper script loaded by Elementor.
Also why it is loading on all pages.
Elementor usually loads all such scripts only if any widget on that page requires it.
But I have found that jQuery Swiper script is loading on all page. Any specific reason for this?

Also please update the swiper library to the latest version as soon as possible.

@arielk arielk added this to the 2.1.0 milestone Jun 13, 2018

@arielk arielk added the status/merged label Jul 2, 2018

@arielk arielk closed this Jul 3, 2018

@allonsacks

This comment has been minimized.

Copy link

commented Oct 9, 2018

Would also like to know why swiper is loading on every page.

@bdthemes

This comment has been minimized.

Copy link

commented Oct 31, 2018

Hello admin, Please update it to latest version 4.4.1 because thumb slider (when i try to add custom widget with latest swiper doc) not working with current version :(

@TheMangoTrain

This comment has been minimized.

Copy link

commented Nov 15, 2018

allonsacks: I know, it sucks, doesn't it? This is typical behavior in web development, even beyond Elementor. You'll find the same situation exists with WordPress other plugins. For example, you install WooCommerce, and now its JS/CSS files are loaded on every page of your site. Inspect any other CMS or complex system, and chances are good you'll find the same situation too.

Developers build a tool, but they have no way of knowing where the user will actually use it. So it's much safer, convenient/lazy and cost-effective just to load all resources on every page. The idea is, if it becomes a problem for certain power users, let them figure it out. Anyways, in theory, after the first loading, the files get cached by the client browser, so from this perspective, it's not terrible (this is the discussion-closing counter-argument typically given by developers).

What is the flipside?

The developer would have to make an interface to allow the user fine-grained management of resource loading across pages and posts. Extra work. And to top it off, now you're just made support that much more of a nightmare.

Take a look at this plugin, it helps you do selective-loading of WP plugins. It works. But look at its interface. It's not nice or intuitive. It could be better designed. The point is it is an interface that needs to exist and adds complexity.

@Fanna1119

This comment has been minimized.

Copy link

commented Dec 10, 2018

@arielk I also noticed that swiper.jquery.min.js is loaded without actually being in use. Any reason for this?

@elementor elementor deleted a comment from bainternet Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.