Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Image Max-Width by Pixels and not just Percent #5376

Closed
2 tasks done
d-marvin opened this issue Aug 10, 2018 · 6 comments
Closed
2 tasks done

Allow Image Max-Width by Pixels and not just Percent #5376

d-marvin opened this issue Aug 10, 2018 · 6 comments
Labels
status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged.
Milestone

Comments

@d-marvin
Copy link

d-marvin commented Aug 10, 2018

Prerequisites

  • I have searched for similar features requests in both open and closed tickets and cannot find a duplicate.
  • The feature is still missing in the latest stable version of Elementor ( Elementor Pro. )

What problem is your feature request going to solve? Please describe.
Having max-width option for images to be only percent seems silly as a designer, having used max-width using pixels pretty always in max-width situations. For example, an image that you want to fill 100% of its container but not if its container exceeds 300px. A common use would be a thumbnail in a short left column and its corresponding text in a wide right column. When the device is mobile and those columns stack, that thumbnail can now fill the screen and look silly. YES, there are workarounds, for example having to add something like "selector img {width:100%;max-width:350px;}", which I do very often.

It would just be convenient if the choice of pixels was standard.

Describe the solution you'd like

What would be nice is like this image. Add a switcher to define Max Width by either % or PX
max-width

Thank you!

@willcitizen
Copy link

@d-marvin I know it's not a solution, but I refuse to leave bits of css lying around embedded in widget controls - I created a small sass helper library that matches elementor's media breakpoints and provide some additional flexbox & sizing and squeezing capabilities you can't get from the ui (like making a section 50% width and centered) and then apply those classes as needed.

@black-eye
Copy link

+1

1 similar comment
@TomRaraAvis
Copy link

+1

@beauwalsh
Copy link

100% agree—am I missing something? I can't figure out any reason to have a percentage max-width.

@hufer
Copy link

hufer commented Dec 24, 2018

https://pafe.piotnet.com/#max-width Piotnet Addons For Elementor Max Width Feature

@d-marvin
Copy link
Author

https://pafe.piotnet.com/#max-width Piotnet Addons For Elementor Max Width Feature

Wow, thanks. So much stuff in there are things I end up hand-coding. Most of it are things you'd think would be standard, like inline blocks (and of course improved max-width). I just hope the plugin is more future-proof than my CSS overwrites.

@lior-sh lior-sh added the status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. label Jan 5, 2020
@lior-sh lior-sh added this to the 2.9.0 milestone Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged.
Projects
None yet
Development

No branches or pull requests

7 participants