Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is param type ok in get_render_attribute_string? #7988

Closed
mlbd opened this issue Apr 29, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@mlbd
Copy link

commented Apr 29, 2019

Prerequisites

  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • The issue still exists against the latest stable version of Elementor.

Description

As you can see in here https://code.elementor.com/methods/elementor-element_base-get_render_attribute_string/ param type array|string documented. But there only string should be expected not array.

So, here is my question, there is anyway we can pass array on get_render_attribute_string ?
If yes, then can I have any and example about it. If not then I think docs needs to update as well doc comment where is method written.

By the way thanks for The Great Plugin.

@bainternet

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

@mlbd

nice catch and thanks for reporting, this will be corrected.

KingYes added a commit that referenced this issue Apr 30, 2019

Merge pull request #7995 from bainternet/docs/i-7988
Corrected param type in doc block closes#7988

@KingYes KingYes closed this in fbee659 May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.