Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Toggle & Accordion widgets with new controls #2836

Merged
merged 53 commits into from Jan 4, 2018

Conversation

Projects
None yet
3 participants
@ramiy
Copy link
Contributor

ramiy commented Nov 27, 2017

Related: #2599 and #2431

This PR allows the user to change the Icon Position and Icon Color in the Toggle & Accordion widgets.

elementor-at

NOTE: the Accordion widget already has a position control. This PR adds the same control to the Toggle widgets. As for color control, it's a new control in both widgets.

@ramiy

This comment has been minimized.

Copy link
Contributor Author

ramiy commented Nov 27, 2017

@KingYes Don't merge yet. I need to add two controls to select an Icon and an Active Icon.

@arielk arielk added this to the 1.9.0 milestone Nov 29, 2017

ramiy added some commits Dec 7, 2017

@ramiy

This comment has been minimized.

Copy link
Contributor Author

ramiy commented Dec 7, 2017

New Icon settings:

icon-settings

@ramiy

This comment has been minimized.

Copy link
Contributor Author

ramiy commented Dec 7, 2017

Last version

icon-settings

ramiy added some commits Dec 7, 2017

@ramiy

This comment has been minimized.

Copy link
Contributor Author

ramiy commented Dec 7, 2017

New "Padding" controls added to Accordion and Toggle widgets.

new

@ramiy ramiy changed the title Enhance Toggle & Accordion widgets with icon position and icon color controls Enhance Toggle & Accordion widgets with new controls Dec 7, 2017

@ramiy

This comment has been minimized.

Copy link
Contributor Author

ramiy commented Dec 7, 2017

New "Title HTML Tag" control added to Accordion and Toggle widgets.

title-html-tag

@arielk

This comment has been minimized.

Copy link
Contributor

arielk commented Dec 11, 2017

  1. Toggle & Accordion: Add CSS reset margin/padding for all Headings (theme compatibility)
  2. Accordion: If you remove the icons, the active icon its still there
  3. Toggle: Icon/active is not working at all in the editor
  4. Toggle & Accordion: Remove span and p from the Title HTML Tag control - It’s not block properties

ramiy added some commits Dec 11, 2017

ramiy added some commits Dec 18, 2017

Toggle & Accordion: remove custom "backwards compatibility", use defa…
…ult values with backwards and forward compatibility

@KingYes KingYes merged commit de79ca2 into elementor:release/1.9.0 Jan 4, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@ramiy ramiy deleted the ramiy:toggle-widget branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.