Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add excerpt field to Elementor page settings #2837

Merged
merged 2 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@ramiy
Copy link
Contributor

commented Nov 27, 2017

Related: #1579 (Enhancing the "Page Setting" panel)

page-settings-excerpt

@arielk

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2017

Thanks @ramiy

But you need to check if the current CPT is support excerpt parameter

@ramiy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 27, 2017

@arielk Done.

Tested on Pages that don't support excerpts. And then add excerpt support with Page Excerpt Plugin.

@ramiy

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2017

The PR hides the excerpt field when the post type has no excerpt support. But I think that it would be better to display the excerpt field and mark it with disabled attribute (see #1571).

@KingYes

This comment has been minimized.

Copy link
Member

commented Nov 28, 2017

@arielk Nice catch!

Thanks @ramiy

@KingYes KingYes merged commit 650da01 into elementor:release/1.9.0 Nov 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ramiy ramiy deleted the ramiy:page-settings-excerpt branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.