Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Image Size" control to the "Image Box" widget #3251

Merged
merged 2 commits into from Feb 4, 2018

Conversation

Projects
None yet
4 participants
@ramiy
Copy link
Contributor

commented Jan 20, 2018

Fixing #3098

image-box


This way I can set Custom sizes and use less bandwidth using smaller images!

image-box-custom-sizes

@arielk arielk added this to the 2.0.0 milestone Jan 21, 2018

@arielk

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2018

@KingYes Needs further review of UI team before merge

@ramiy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2018

@kobizz

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2018

Looks good

@KingYes KingYes merged commit 5ac3c0f into elementor:release/2.0.0 Feb 4, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla Contributor License Agreement is signed.
Details

@ramiy ramiy deleted the ramiy:image-box branch Feb 4, 2018

@ramiy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2018

@KingYes Ok, so we have a problem with this PR, the new control uses the image_size name.

But this specific widget already uses the image_size name in a different control.

This is why Travis failed. I see a PHP notice in my debug.log file.

@ramiy ramiy restored the ramiy:image-box branch Feb 4, 2018

@ramiy ramiy referenced this pull request Feb 14, 2018

Merged

Bug fix: Image size control #3383

@ramiy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2018

Also fixing #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.