Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Video widget accessibility #3270

Merged
merged 2 commits into from Jan 22, 2018

Conversation

Projects
None yet
3 participants
@ramiy
Copy link
Contributor

commented Jan 21, 2018

Description

The video widget need some accessibility love!

  1. Name - The iframe should have an accessibility name (https://fae.disability.illinois.edu/rulesets/FRAME_2/), either title or aria-label tags.

  2. Action - The play icon should have some text saying "Play video" or some thing like that. Currently, regular visitors see the play button and understand that clicking the icon actives the video, but blind people don't see the icon. We need to add an assistive text for them.

  3. Markup - The play icon wrapper is a <div>, it should be a <button>. The second approach is to add role="button" to the <div> tag.

video-a11y

@ramiy ramiy changed the title a11y: Video widget accessibility a11y: add assistive technologies text near the play video icon Jan 21, 2018

@ramiy ramiy changed the title a11y: add assistive technologies text near the play video icon a11y: add assistive technologies text near the play icon Jan 21, 2018

@ramiy ramiy changed the title a11y: add assistive technologies text near the play icon a11y: Video widget accessibility Jan 21, 2018

@KingYes KingYes merged commit ffce581 into elementor:release/2.0.0 Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ramiy ramiy deleted the ramiy:a11y-video branch Jan 22, 2018

@ashybaye

This comment has been minimized.

Copy link

commented Jan 11, 2019

@ramiy
Hello! Trying to make sure that the video components are indeed passing the accessibility checks. Was the title attribute added to the iframes? I still can't see it in the code when adding videos. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.