Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Icon Box widget accessibility #3273

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
2 participants
@ramiy
Copy link
Contributor

ramiy commented Jan 21, 2018

Description

The icon box widget need some accessibility love!

The Icon box has 3 elements: <i> icon, the title with custom HTML tag controlled by the user, and a description paragraph in <p>.

The <i> icon is used for pure decoration or visual styling, and it should not be displayed to an assistive technology-using user. We need to add aria-hidden="true" to the markup.

icon-box

@ramiy ramiy changed the title a11y: Icon Box widget accessibility a11y: add `aria-hidden="true"` to the icon box widget Jan 21, 2018

@ramiy ramiy changed the title a11y: add `aria-hidden="true"` to the icon box widget a11y: Icon Box widget accessibility Jan 21, 2018

@KingYes KingYes merged commit e7b5c06 into elementor:release/2.0.0 Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@ramiy ramiy deleted the ramiy:a11y-icon-box branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.