Google api link being stripped

[tchorst]

Has anyone encountered link to both Googleapis and bootstrapcdn being stripped out? After processing, the src="" for both of these script calls are empty, when before they contained links to js files.

[tchorst]

It also appears to be stripping out query strings, including links to Google search and youtube videos. There doesn't seem to be a setting that dictates this. Is there a way to prevent it?

[leonstafford]

Hi @tchorst, will be reviewing this as part of version 7 development, where rewriting mechanism has been overhauled.

External link's query strings should not be touched, but for internal links, I'll need to check options....

What's a use case for an internal query string you'd need preserved?

ie, something on /my-custom-page/?width=100&height=50 to do sever-side image processing will not be of any use. The URL we save to disk cannot have any query strings in it, but there may be a good reason to not strip them from links in the source code...

[tchorst]

Hi @leonstafford

It's the external links we seem to be having an issue with, sorry I wan't clearer. In the screens I posted, the bottom image is the live site, and the top image is the export. Note how the link in the ahref is missing the parameters being passed to Google. In my first port, the complete links are being removed.

[leonstafford]

OK, definite bug. Likely fixed in upcoming release, will review soon

[tchorst]

Great, thanks!

[stevygee]

Hi, I think I'm having the same issue with 7.0-build0002, wp2static strips all external URLs in <img src and <a href attributes. Just tried on a fresh WP with TwentyNineteen and no other plugins active. I'm not sure if this is also an issue in the latest dev state.

[mrksdiehl]

Hey. I was facing the same issue and am pretty sure I found the problem.
In HTMLProcessor.php in the rewriteLocalURL function (line 288 in my version), the function does check various cases in which no url rewrite is necessary. In the case that no rewrite is necessary it does not return the url back though.
So I just added return $url; at each case. Looks like this now:

if ( URLHelper::startsWithHash( $url ) ){ 
    return $url;
}

if ( URLHelper::isMailto( $url ) ){
    return $url;
}

if ( ! URLHelper::isInternalLink( $url, $this->site_url_host ) ) {
    return $url;
}

Not sure if it does help your case, but it definitely helped me!

[leonstafford]

Hi all,

V7 now has a cleaner rewriting engine in it's core, with advanced CSS/HTML processors moving into their own add-ons. Google URL issue should no longer be a problem.

Builds ready for testing here: https://github.com/WP2Static/wp2static/releases/tag/7.0-alpha-003

[leonstafford]

I've tested this with both an https:// and // googleapis script tag and wasn't able to reproduce. Have recently done tidy up of this v6 codebase that may have fixed it.

Added an extra test to the isInternalLink test to be safe. Please reopen if same issue persists and will look elsewhere for the offending code.

[leonstafford]

^ expected to be working in at least v6.6.9 onwards