Improve: Jquery gets elements by Id. #73

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@denniscastro

Before: just get first elemment
Now: gets all the elements with same Id

@denniscastro denniscastro Improve: Jquery gets elements by Id.
Before: just get first elemment
Now: gets all the elements with same Id
6ed344f
@iamvery

Its probably a bad idea overall to have duplicate HTML id attributes on the page anyway. Since this lib does so when multi-day events "wrap", it'd probably be a good idea to revert back to the "class style" event identification (i.e. ec-event-1234) and additionally include a more general class ec-event along with it).

For that matter, couldn't you even match the CSS class ec-event-1234 with something like [class*="ec-event"]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment