Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split configuration into Development/Production and, maybe Standalone #53

Open
ravenvz opened this issue Jul 7, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@ravenvz
Copy link
Contributor

commented Jul 7, 2015

Right now, to start playing around with local version of the app, quite a few
changes have to be made. For example, here are steps I had to do:

  • It does not make much sense for me to use PostgreSQL on local machine,
    so I had to alter requirements.txt to not include psycopg2 adapter;
  • I had to change App config to use sqlite db;
  • A had to use a hack to bypass GitHub authorization.

Steps like these are tedious to do by hand and should be handled by configuration files.
I think, that separation of configuration would help new contributors to get started more quickly.

This issue intersects with #10, as it would probably require separate configuration anyway.
If this proposal is accepted, I could work on it. Please let me know if it makes sense.

@eleweek

This comment has been minimized.

Copy link
Owner

commented Jul 7, 2015

This totally makes sense, I'll start working on this today.

@eleweek

This comment has been minimized.

Copy link
Owner

commented Jul 7, 2015

Hey, I added some work to address these issues, and I updated README file to include basic installation guide. Could you please check it?

@ravenvz ravenvz referenced this issue Jul 8, 2015

Merged

Update README.md #54

@ravenvz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2015

Great! I have checked it and it looks like everything is working fine (I only checked standalone version). I added some additional clarifications to README.md.

@ravenvz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2015

I would also like to try to move configuration part from app.py file to separate file, something along the lines of Development/Production section of flask documentation

http://flask.pocoo.org/docs/0.10/config/

Now, I would like to do this for myself in any case to get more familiar with Flask framework in the process, but if you are interested, I can make a PR if I like the result.

@eleweek

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2015

Thanks, I accepted the PR. As for configuration management, is there any advantage over using .env + foreman?

@ravenvz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2015

Well, I had studied foreman more closely since the time from my last post (never used it before), and it turns out that there will probably be no advantage at all, so - never mind!

I guess that issue is resolved then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.