From eb0a59f770f0bbaccd9c1b1fd791cae0c147e992 Mon Sep 17 00:00:00 2001 From: Peter Waller Date: Tue, 8 Aug 2023 11:18:19 +0100 Subject: [PATCH] [NFCI] Use scope rather than drop for file lifetime Addresses a review comment in #107. --- src/repo/repository.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/repo/repository.rs b/src/repo/repository.rs index 6b7b864..a637eb0 100644 --- a/src/repo/repository.rs +++ b/src/repo/repository.rs @@ -584,10 +584,12 @@ impl Repository { let pack_entries = run_in_parallel(threads, files.into_iter(), |file_path| { let mut fd = File::open(&file_path)?; - let mut buf = vec![]; - fd.read_to_end(&mut buf)?; - let mode = fd.metadata()?.permissions().mode(); - drop(fd); + let (buf, mode) = { + let mut buf = vec![]; + fd.read_to_end(&mut buf)?; + let mode = fd.metadata()?.permissions().mode(); + (buf, mode) + }; let mut checksum = [0u8; 20]; let mut hasher = Sha1::new(); hasher.input(&buf);