Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make it possible to display japanese/chinese fonts #153
I modified this PR: #152
Here is the original description.
Hi. I am trying to use docker-selenium and Zalenium in the company I am working for. I think Zalenium is one of the best solution to run E2E tests with Docker, so I really want to use it.
However, I found that docker-selenium and Zalenium cannot correctly display Japanese web pages because they do not have Japanese fonts.
In order to solve this problem, I added Japanese font and Chinese font in the Dockerfile. In this way, docker-selenium became possible to display Japanese and Chinese web pages. While the layer size becomes bigger, I think that this change is useful.
Here is the screenshot of the Japanese Facebook page at https://ja-jp.facebook.com/ that I took with the original elgalu/selenium Docker image.
Chinese Facebook page at https://zh-cn.facebook.com/
Here are the screenshots I took with the modified Docker image.
referenced this pull request
May 9, 2017
May 9, 2017
added a commit
this pull request
May 11, 2017
Change released today:
Thanks for contributing!