New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to display japanese/chinese fonts #153

Merged
merged 1 commit into from May 9, 2017

Conversation

2 participants
@katryo
Contributor

katryo commented May 9, 2017

I modified this PR: #152

Here is the original description.


Hi. I am trying to use docker-selenium and Zalenium in the company I am working for. I think Zalenium is one of the best solution to run E2E tests with Docker, so I really want to use it.

However, I found that docker-selenium and Zalenium cannot correctly display Japanese web pages because they do not have Japanese fonts.

In order to solve this problem, I added Japanese font and Chinese font in the Dockerfile. In this way, docker-selenium became possible to display Japanese and Chinese web pages. While the layer size becomes bigger, I think that this change is useful.

Before

Here is the screenshot of the Japanese Facebook page at https://ja-jp.facebook.com/ that I took with the original elgalu/selenium Docker image.

vid_chrome_25550_webm 3

Chinese Facebook page at https://zh-cn.facebook.com/

vid_chrome_25550_webm 4

After

Here are the screenshots I took with the modified Docker image.

vid_chrome_25550_webm

vid_chrome_25550_webm 5

@elgalu elgalu merged commit f269ce6 into elgalu:master May 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

elgalu added a commit that referenced this pull request May 11, 2017

@elgalu

This comment has been minimized.

Show comment
Hide comment
@elgalu

elgalu May 11, 2017

Owner

Change released today:
https://github.com/elgalu/docker-selenium/releases/tag/3.3.1-p8

Thanks for contributing!

Owner

elgalu commented May 11, 2017

Change released today:
https://github.com/elgalu/docker-selenium/releases/tag/3.3.1-p8

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment