From 8270774661b92c7d070d99956a018a9252984e01 Mon Sep 17 00:00:00 2001
From: Diego Molina <diemol@gmail.com>
Date: Mon, 29 Oct 2018 13:46:58 +0100
Subject: [PATCH] Fixing video recording so it works in all browsers. Fixes
 #263

---
 Dockerfile                       | 2 +-
 video-rec/bin/start-video-rec.sh | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 461f5306..f818af17 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -932,7 +932,7 @@ ENV FIREFOX_VERSION="${FF_VER}" \
   FIREFOX="true" \
   MULTINODE="false" \
   FFMPEG_FRAME_RATE=10 \
-  FFMPEG_CODEC_ARGS="-crf 0 -preset ultrafast -qp 0 -pix_fmt yuv420p" \
+  FFMPEG_CODEC_ARGS="-vcodec libx264 -preset ultrafast -pix_fmt yuv420p" \
   FFMPEG_FINAL_CRF=0 \
   FFMPEG_DRAW_MOUSE=1 \
   VIDEO_TMP_FILE_EXTENSION="mkv" \
diff --git a/video-rec/bin/start-video-rec.sh b/video-rec/bin/start-video-rec.sh
index b5acf28f..ba94ce37 100755
--- a/video-rec/bin/start-video-rec.sh
+++ b/video-rec/bin/start-video-rec.sh
@@ -48,13 +48,13 @@ fi
 
 # avconv or ffmpeg
 ffmpeg -f x11grab \
-  -framerate ${FFMPEG_FRAME_RATE} \
-  -video_size ${FFMPEG_FRAME_SIZE} \
-  -i "${DISPLAY}.0+0,0" \
+  -s ${FFMPEG_FRAME_SIZE} \
+  -i "${DISPLAY}.0" \
   -draw_mouse ${FFMPEG_DRAW_MOUSE} \
   ${FFMPEG_CODEC_ARGS} \
-  -segment_format_options movflags=+faststart \
+  -r ${FFMPEG_FRAME_RATE} \
   -y -an "${tmp_video_path}" 2>&1 &
+
 VID_TOOL_PID=$!
 
 # Exit all child processes properly