Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project travis and tox builds #10

Merged
merged 8 commits into from Feb 18, 2019

Conversation

AlmogCohen
Copy link
Contributor

Following the accepted PRs, I propose this PR that basically fix the build issues with this project by fixing the tox.ini file to properly work with pipenv.

Following the accepted PRs, I propose this PR that basically fix the build issues with this project by fixing the tox.ini file to properly work with `pipenv`.
@AlmogCohen
Copy link
Contributor Author

AlmogCohen commented Jan 22, 2019

@elgertam As you can see on my personal Travis build https://travis-ci.com/AlmogCohen/cookiecutter-pipenv/builds/98225790

This PR would fix the build for this project by using changes I've already proposed in other PRs. What I did here is to fix the pytest command run

@AlmogCohen
Copy link
Contributor Author

Wait a moment, it is still broken for some reason. Maybe the Pipfile.lock

@AlmogCohen AlmogCohen changed the title Fix project travis and tox builds WIP: Fix project travis and tox builds Jan 22, 2019
@AlmogCohen
Copy link
Contributor Author

Travis build passes for this branch...which is nice to prove a point https://travis-ci.com/AlmogCohen/cookiecutter-pipenv. Ready for a merge

@AlmogCohen AlmogCohen changed the title WIP: Fix project travis and tox builds Fix project travis and tox builds Jan 22, 2019
Pipfile Show resolved Hide resolved
@@ -2,6 +2,12 @@
Cookiecutter Python Package Template with Pipenv
================================================

|travis|

.. |travis| image:: https://travis-ci.com/elgertam/cookiecutter-pipenv.svg?branch=master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we just need the owner of the repo to enable builds on travis ;) next step we could fix the PyPi deployment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no pressure though

@AlmogCohen
Copy link
Contributor Author

Pypy3.5 break the travis build at the moment as pipenv does not officially support pypy (which is odd). It is all mentioned here: pypa/pipenv#3313

For now, I'll simply drop the pypy3.5 from the build. (Another option is to pin the pipenv version but I'd rather not do that at the moment)

@AlmogCohen
Copy link
Contributor Author

@elgertam bump... I'll just point out that the travis build of this exact branch is passing successfully on my fork https://travis-ci.com/AlmogCohen/cookiecutter-pipenv so not sure if local testing is necessary. I do respect your decision on that :)

Pipfile Outdated Show resolved Hide resolved
@AlmogCohen
Copy link
Contributor Author

done

@elgertam elgertam merged commit 220b380 into elgertam:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants