ActiveAdmin::FormBuilder monkey patch is identical to ActiveAdmin code #10

Merged
merged 2 commits into from Jul 5, 2012

Projects

None yet

2 participants

@jpmckinney
Contributor

It's not needed, so we should remove it.

@elia
Owner
elia commented Jul 5, 2012

Can you point the AA source where they're equal?

@jpmckinney
Contributor

https://github.com/gregbell/active_admin/blob/master/lib/active_admin/form_builder.rb#L11

Only difference is you open the block with do ... end and have an extra comment.

@elia
Owner
elia commented Jul 5, 2012

Thanks!

…we should start testing by now :\ I'm starting to feel uneasy without them :)

@elia elia merged commit 9c877bb into elia:master Jul 5, 2012
@jpmckinney
Contributor

Cool, thanks for merging! For the changes mentioned in #13, do I need to make new pull requests, or can you just do:

git remote add jpmckinney https://github.com/jpmckinney/activeadmin-mongoid.git
git pull jpmckinney master
@elia
Owner
elia commented Jul 5, 2012

funny I just asked about this on #13 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment