Added /ping to /api/v2 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsh-0
suggested changes
Mar 27, 2017
src/publisher/api_v2_urls.py
Outdated
| @@ -2,6 +2,7 @@ | |||
| from . import api_v2_views as views | |||
|
|
|||
| urlpatterns = [ | |||
| url(r'/ping$', views.ping, name='ping'), | |||
src/publisher/api_v2_views.py
Outdated
| def ping(request): | ||
| "returns a test response" | ||
| # produce standard authenticated header | ||
| is_authenticated(request) |
There was a problem hiding this comment.
this isn't doing anything. is_authenticated has no side effects
src/publisher/api_v2_views.py
Outdated
| "returns a test response" | ||
| # produce standard authenticated header | ||
| is_authenticated(request) | ||
| return Response('pong', content_type='text/plain; charset=UTF-8', headers={'Cache-Control': 'must-revalidate, no-cache, no-store, private'}) |
There was a problem hiding this comment.
if these cache headers are different for the /ping endpoint than for all the others, then this is fine, otherwise, caching headers are handled in custom middleware in core.middleware (beneath the kong authentication middleware) and this can be removed.
| resp = self.c.get(reverse('v2:ping')) | ||
| self.assertEqual(resp.status_code, 200) | ||
| self.assertEqual(resp.content_type, 'text/plain; charset=UTF-8') | ||
| self.assertEqual(resp['Cache-Control'], 'must-revalidate, no-cache, no-store, private') |
There was a problem hiding this comment.
again, double handling if /ping cache headers are no different from regular caching headers.
Documenting why the cache headers are different
|
Changes made |
lsh-0
approved these changes
Mar 28, 2017
|
For some reason this failed when in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be targeted by journal in its status page and possibly by monitoring.