New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -beta suffix from CFBundleShortVersionString #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@eliperkins
Owner

eliperkins commented Oct 15, 2018

What does this PR do?

This allows for the framework to be used in Swift 4 projects who consume this framework from Carthage, to be submitted to the App Store.

Closes segmentio#794

Where should the reviewer start?

By reading segmentio#794

How should this be manually tested?

Create a project with Swift 4, consume this framework with Carthage, and then submit it to the App Store 馃槄

Any background context you want to provide?

segmentio#794

What are the relevant tickets?

segmentio#794

Remove -beta suffix from CFBundleShortVersionString
This allows for the framework to be used in projects submitted to the App Store.

Closes segmentio#794

@eliperkins eliperkins closed this Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment