Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new fetcher for Puppeteer based JS rendering #272

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

oltarasenko
Copy link
Collaborator

Creates a splash replacement. I have tested it with just one target so far, it's hard to say it's perfect, but it might be an alternative to splash that is seems to be a bit dead right now

Creates a splash replacement. I have tested it with just one target so far,
it's hard to say it's perfect, but it might be an alternative to splash
that is seems to be a bit dead right now
Copy link

github-actions bot commented Apr 9, 2024

Tests summary

Finished in 10.6 seconds (0.5s async, 10.1s sync)
Randomized with seed 216268

0 failures (131 tests)
77.38% coverage (75% is the minimum)

Coverage details
Percentage | Module
-----------|--------------------------
     0.00% | Crawly.Fetchers.Splash
     0.00% | Crawly.Loggers.SendToUiBackend
     0.00% | Crawly.Response
     0.00% | Mix.Tasks.Crawly.Gen.Config
     0.00% | String.Chars.Crawly.Request
     0.00% | UtilsTestSpider
    40.00% | PipelineTestSpider
    42.86% | TestSpider
    55.56% | Mix.Tasks.Crawly.Gen.Spider
    61.49% | Crawly.API.Router
    61.54% | Crawly.Models.YMLSpider
    66.67% | Crawly.Models.Job
    75.00% | Crawly.Pipelines.JSONEncoder
    76.47% | Crawly.SimpleStorage
    76.92% | Crawly.Fetchers.CrawlyRenderServer
    77.78% | Crawly.Pipelines.Experimental.SendToUI
    80.00% | Crawly.EngineSup
    80.77% | Crawly
    82.61% | Crawly.Pipelines.WriteToFile
    83.33% | Crawly.Middlewares.UserAgent
    85.33% | Crawly.Engine
    87.50% | Crawly.Application
    87.50% | TestUtils
    88.37% | Crawly.RequestsStorage
    88.46% | Crawly.RequestsStorage.Worker
    89.06% | Crawly.Manager
    90.00% | Crawly.Pipelines.Validate
    91.84% | Crawly.Worker
    92.05% | Crawly.Utils
    92.11% | Crawly.DataStorage
    92.86% | Crawly.DataStorage.Worker
   100.00% | Crawly.Fetchers.Fetcher
   100.00% | Crawly.Fetchers.HTTPoisonFetcher
   100.00% | Crawly.ManagerSup
   100.00% | Crawly.Middlewares.AutoCookiesManager
   100.00% | Crawly.Middlewares.DomainFilter
   100.00% | Crawly.Middlewares.RequestOptions
   100.00% | Crawly.Middlewares.RobotsTxt
   100.00% | Crawly.Middlewares.SameDomainFilter
   100.00% | Crawly.Middlewares.UniqueRequest
   100.00% | Crawly.ParsedItem
   100.00% | Crawly.Pipeline
   100.00% | Crawly.Pipelines.CSVEncoder
   100.00% | Crawly.Pipelines.DuplicatesFilter
   100.00% | Crawly.Request
   100.00% | Crawly.Settings
   100.00% | Crawly.Spider
-----------|--------------------------
    77.38% | Total

@oltarasenko oltarasenko merged commit cdc3727 into master Apr 9, 2024
1 check passed
@oltarasenko oltarasenko deleted the render_server_integration branch April 9, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant