From 5bbacf026629d6deeace952b02a6b1a3697505c6 Mon Sep 17 00:00:00 2001 From: Greg Rychlewski Date: Wed, 5 Nov 2025 23:40:06 -0500 Subject: [PATCH 1/3] remove sensitive options before calling after_connect --- lib/db_connection/connection.ex | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/db_connection/connection.ex b/lib/db_connection/connection.ex index b0f2eb6..c181bcf 100644 --- a/lib/db_connection/connection.ex +++ b/lib/db_connection/connection.ex @@ -9,6 +9,7 @@ defmodule DBConnection.Connection do alias DBConnection.Util @timeout 15_000 + @sensitive_opts [:after_connect, :parameters, :hostname, :port, :username, :password, :database] @doc false def start_link(mod, opts, pool, tag) do @@ -229,11 +230,13 @@ defmodule DBConnection.Connection do opts: opts } = s + notify_connection_listeners(:connected, s) case apply(mod, :checkout, [state]) do {:ok, state} -> opts = [timeout: timeout] ++ opts + opts = Keyword.drop(opts, @sensitive_opts) {pid, ref} = DBConnection.Task.run_child(mod, state, after_connect, opts) timer = start_timer(pid, timeout) s = %{s | client: {ref, :after_connect}, timer: timer, state: state} From 891749ce9dbf3e0a1d3385858b4785340e0df7a4 Mon Sep 17 00:00:00 2001 From: Greg Rychlewski Date: Wed, 5 Nov 2025 23:47:00 -0500 Subject: [PATCH 2/3] format --- lib/db_connection/connection.ex | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/db_connection/connection.ex b/lib/db_connection/connection.ex index c181bcf..159fc2b 100644 --- a/lib/db_connection/connection.ex +++ b/lib/db_connection/connection.ex @@ -230,7 +230,6 @@ defmodule DBConnection.Connection do opts: opts } = s - notify_connection_listeners(:connected, s) case apply(mod, :checkout, [state]) do From 888744c2fec67134d70ba60c651b1adc16b56e04 Mon Sep 17 00:00:00 2001 From: Greg Rychlewski Date: Wed, 5 Nov 2025 23:56:46 -0500 Subject: [PATCH 3/3] fix opts --- lib/db_connection/connection.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/db_connection/connection.ex b/lib/db_connection/connection.ex index 159fc2b..3d466ed 100644 --- a/lib/db_connection/connection.ex +++ b/lib/db_connection/connection.ex @@ -9,7 +9,7 @@ defmodule DBConnection.Connection do alias DBConnection.Util @timeout 15_000 - @sensitive_opts [:after_connect, :parameters, :hostname, :port, :username, :password, :database] + @sensitive_opts [:parameters, :hostname, :port, :username, :password, :database] @doc false def start_link(mod, opts, pool, tag) do