Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi how-to #3015

Merged
merged 3 commits into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@msaraiva
Copy link
Contributor

commented Jun 7, 2019

No description provided.

|> case do
{:ok, %{transfer: transfer}} ->
# Handle success case
{:error, name, value, rolled_back_changes} ->

This comment has been minimized.

Copy link
@AndrewDryga

AndrewDryga Jun 7, 2019

Member

I think rolled_back_changes is a misleading name. One of Multi steps can contain a function which result is not rolled back along with DB transaction.

This comment has been minimized.

Copy link
@josevalim

josevalim Jun 7, 2019

Member
Suggested change
{:error, name, value, rolled_back_changes} ->
{:error, name, value, changes_so_far} ->
@josevalim

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Looks great!

@josevalim josevalim merged commit 3ebf89c into elixir-ecto:master Jun 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josevalim

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

❤️ 💚 💙 💛 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.