Add small clarification to Ecto.Query docs - #4051
Merged
Merged
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
greg-rychlewski
pushed a commit
to greg-rychlewski/ecto
that referenced
this pull request
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sense to me, not sure if this makes sense to other people. LMK if this makes sense.
Motivation
I was trying to find out if Ecto.Query functions would query the DB. Some examples call
Repofunctions so they imply thatRepomust be used but it isn't too explicit. For instanceEcto.Query.preload/3has this description:which sounds a lot like
Ecto.Repo.preload/3Ecto.Repo.preload/3also includes this bit, which makes sense but not while doubting whether Query.preload will fetch or not.