has_one does not support preload_order option #4682
Merged
+15
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
has_oneandhas_manyboth validate against the same@valid_has_optionsallowing you to pass apreload_orderoption intohas_onedespite it not being supported.There is a PR (#4505) that's been open for over a year with some discussion around
has_onesupportingpreload_orderbut it would probably be good to clean this up in the meantime.