From 043da675d9bc3e9fefb760ca397f25c65614579b Mon Sep 17 00:00:00 2001 From: Greg Rychlewski Date: Tue, 8 Oct 2024 18:27:49 -0400 Subject: [PATCH 1/2] proper range increment --- lib/ecto/adapters/myxql/connection.ex | 2 +- lib/ecto/adapters/postgres/connection.ex | 2 +- lib/ecto/adapters/tds/connection.ex | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ecto/adapters/myxql/connection.ex b/lib/ecto/adapters/myxql/connection.ex index cc951c50..a151b585 100644 --- a/lib/ecto/adapters/myxql/connection.ex +++ b/lib/ecto/adapters/myxql/connection.ex @@ -881,7 +881,7 @@ if Code.ensure_loaded?(MyXQL) do end defp values_list(types, num_rows, query) do - rows = Enum.to_list(1..num_rows) + rows = Enum.to_list(1..num_rows//1) [ "VALUES ", diff --git a/lib/ecto/adapters/postgres/connection.ex b/lib/ecto/adapters/postgres/connection.ex index 42f3d5ae..fd6f0fee 100644 --- a/lib/ecto/adapters/postgres/connection.ex +++ b/lib/ecto/adapters/postgres/connection.ex @@ -1137,7 +1137,7 @@ if Code.ensure_loaded?(Postgrex) do end defp values_list(types, idx, num_rows) do - rows = Enum.to_list(1..num_rows) + rows = Enum.to_list(1..num_rows//1) [ "VALUES ", diff --git a/lib/ecto/adapters/tds/connection.ex b/lib/ecto/adapters/tds/connection.ex index 23235201..8ec0eb43 100644 --- a/lib/ecto/adapters/tds/connection.ex +++ b/lib/ecto/adapters/tds/connection.ex @@ -981,7 +981,7 @@ if Code.ensure_loaded?(Tds) do end defp values_list(types, idx, num_rows) do - rows = Enum.to_list(1..num_rows) + rows = Enum.to_list(1..num_rows//1) [ "VALUES ", From 47b5058e02e6ee02552704d625182c3ed332b5a6 Mon Sep 17 00:00:00 2001 From: Greg Rychlewski Date: Tue, 8 Oct 2024 18:37:31 -0400 Subject: [PATCH 2/2] review comment --- lib/ecto/adapters/myxql/connection.ex | 2 +- lib/ecto/adapters/postgres/connection.ex | 2 +- lib/ecto/adapters/tds/connection.ex | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ecto/adapters/myxql/connection.ex b/lib/ecto/adapters/myxql/connection.ex index a151b585..59a09d1f 100644 --- a/lib/ecto/adapters/myxql/connection.ex +++ b/lib/ecto/adapters/myxql/connection.ex @@ -881,7 +881,7 @@ if Code.ensure_loaded?(MyXQL) do end defp values_list(types, num_rows, query) do - rows = Enum.to_list(1..num_rows//1) + rows = :lists.seq(1, num_rows, 1) [ "VALUES ", diff --git a/lib/ecto/adapters/postgres/connection.ex b/lib/ecto/adapters/postgres/connection.ex index fd6f0fee..996e8e18 100644 --- a/lib/ecto/adapters/postgres/connection.ex +++ b/lib/ecto/adapters/postgres/connection.ex @@ -1137,7 +1137,7 @@ if Code.ensure_loaded?(Postgrex) do end defp values_list(types, idx, num_rows) do - rows = Enum.to_list(1..num_rows//1) + rows = :lists.seq(1, num_rows, 1) [ "VALUES ", diff --git a/lib/ecto/adapters/tds/connection.ex b/lib/ecto/adapters/tds/connection.ex index 8ec0eb43..9eeeb0b4 100644 --- a/lib/ecto/adapters/tds/connection.ex +++ b/lib/ecto/adapters/tds/connection.ex @@ -981,7 +981,7 @@ if Code.ensure_loaded?(Tds) do end defp values_list(types, idx, num_rows) do - rows = Enum.to_list(1..num_rows//1) + rows = :lists.seq(1, num_rows, 1) [ "VALUES ",