New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache_statement to query #407

Merged
merged 3 commits into from Oct 7, 2018

Conversation

Projects
None yet
2 participants
@josevalim
Copy link
Member

josevalim commented Sep 24, 2018

No description provided.

@josevalim josevalim changed the title Add cache_statemet to query Add cache_statement to query Sep 24, 2018

@josevalim josevalim added this to the v0.14 milestone Sep 28, 2018

@josevalim

This comment has been minimized.

Copy link
Member

josevalim commented Sep 30, 2018

Need to get a test from alter_test and make sure the cache gets cleared.

@josevalim

This comment has been minimized.

Copy link
Member

josevalim commented Oct 2, 2018

@fishcakez I have added a commit that cleans up the cache and retries the query on feature_not_supported. You can see that I am doing this clean up on all queries, even on the prepared ones. If this is not advised, I can update the guard.

@josevalim josevalim merged commit 53e0090 into master Oct 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@josevalim

This comment has been minimized.

Copy link
Member

josevalim commented Oct 7, 2018

❤️ 💚 💙 💛 💜

@josevalim josevalim deleted the jv-cache-statement branch Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment