Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map keys regex crashes/zombifies emacs master #445

Closed
deadtrickster opened this issue Oct 15, 2019 · 6 comments · Fixed by #448
Closed

Map keys regex crashes/zombifies emacs master #445

deadtrickster opened this issue Oct 15, 2019 · 6 comments · Fixed by #448

Comments

@deadtrickster
Copy link

Hi,

when I try open elixir file on emacs master. emacs completely freezes. C-g, ESC nothing can help.
This happened a couple of weeks ago and today I decided to dig into this and found these lines:

(,(elixir-rx (group (and (one-or-more identifiers) ":")) space)
     1 elixir-atom-face)

If I replace it with

(,(elixir-rx (group (and identifiers ":")) space)
     1 elixir-atom-face)

everything is ok.

Probably bug in emacs rx module? I'm not sure... Why one-or-more?

Thanks

@victorolinasc
Copy link
Contributor

@deadtrickster I've been having this issue even without opening elixir-mode on current master of Emacs. Are you also having this issue outside elixir? I too think is a regex bug on Emacs ...

@deadtrickster
Copy link
Author

nope, i don't. but i use handful of modes anyways.

@nykma
Copy link

nykma commented Oct 29, 2019

Also experienced the "complete freeze" here.
After some profiling, I found that font-lock-fontify-keywords-region takes a huge mount of CPU.
Maybe it's also related to this case?

BTW, I'm using Emacs 27.0.50

@jsmestad
Copy link
Contributor

jsmestad commented Nov 1, 2019

I think I am hitting this as well. At first I thought it was due to lsp-mode (even went as far to report a false bug at emacs-lsp/lsp-mode#1143). I want to link it here so others can track this issue.

@jsmestad
Copy link
Contributor

jsmestad commented Nov 1, 2019

@deadtrickster has that patch been working for you? It may be worth pushing it in as a PR.

@dgutov
Copy link
Contributor

dgutov commented Nov 27, 2019

I just opened #448 which contains a more comprehensive cleanup, and a good explanation. Please check it out, everyone.

J3RN pushed a commit to J3RN/emacs-elixir that referenced this issue Apr 24, 2021
This makes a setup possible in which a symlink points to the file
(e.g. /usr/local/bin/elixir-ls -> /opt/elixir-ls/language_server.sh).

Co-authored-by: Joshua Trees <me@jtrees.io>
J3RN pushed a commit to J3RN/emacs-elixir that referenced this issue Apr 24, 2021
J3RN pushed a commit to J3RN/emacs-elixir that referenced this issue Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants