Move Galaxy showcase out of sandbox - #180
Merged
Merged
Conversation
wm75
commented
Apr 17, 2023
Collaborator
|
Closes #167 |
rabuono
reviewed
Apr 18, 2023
rabuono
left a comment
rabuono
left a comment
Collaborator
There was a problem hiding this comment.
I managed a first pass
Can you please check the suggestions and commit what you agree with?
Then I can give it another go.
We should add a few items to the "tools and resources table".
Also might be worth moving the how to reuse the components to inside of what can you use this showcase for
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Contributor
Author
@rabuono I'm not sure about this. A collection like you imagine even exists: https://workflowhub.eu/collections/2 (so was even the second collection ever created :). |
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Contributor
Author
|
Apart from the workflowhub collection idea and the open question about the link to the Galaxy project, I think I've addressed all your review comments, @rabuono. |
rabuono
reviewed
Apr 24, 2023
Collaborator
I see your point. I added a minor change to try and make more clear that the workflows are an evolving list. Since the link is to a query result, the workflows that are going to be found will depend on which workflows are present with those tags at the time of the visit to WorkflowHub |
rabuono
reviewed
Apr 24, 2023
rabuono
reviewed
Apr 24, 2023
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
rabuono
reviewed
Apr 25, 2023
rabuono
reviewed
May 2, 2023
rabuono
approved these changes
May 2, 2023
rabuono
left a comment
rabuono
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to go for me!
Thank you
bedroesb
pushed a commit
that referenced
this pull request
May 3, 2023
* Add Galaxy Covid19 showcase * Some more fixes * Add wm75 to contributors * Add Acknowledgments section * Add covid19-galaxy to sidebar * change page id to snake-case * Update ENA logo * Fix Galaxy Europe link :) * Add sponsors section * First round of applying code review suggestions Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Improve presentation of reusability * Update image description according to review comment Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/covid19-galaxy.md * Apply suggestions from code review Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Accept reviewer suggestion for rewrite of paragraph Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/covid19-galaxy.md * Update showcase/covid19-galaxy.md --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
bedroesb
pushed a commit
that referenced
this pull request
May 3, 2023
* Add Galaxy Covid19 showcase * Some more fixes * Add wm75 to contributors * Add Acknowledgments section * Add covid19-galaxy to sidebar * change page id to snake-case * Update ENA logo * Fix Galaxy Europe link :) * Add sponsors section * First round of applying code review suggestions Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Improve presentation of reusability * Update image description according to review comment Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/covid19-galaxy.md * Apply suggestions from code review Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Accept reviewer suggestion for rewrite of paragraph Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/covid19-galaxy.md * Update showcase/covid19-galaxy.md --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
rabuono
added a commit
that referenced
this pull request
Jun 27, 2023
* Create korogenoest Estonian showcase for sars-cov-sequencing * KoroGenoEst graphical abstract (#178) Figure for Estonian showcase * recommended dataflow (#177) Recommended dataflow image for korogenoest showcase * chang to markdown * add korogenoest to sidebar * start adding Diana * remove template comments from text * Sweden national page (#150) * Add Swedish national page * minor corrections * correct postcovid name * remove search exclude field * update sidebar * add space Added space between affiliations to match other contributors * Remove access info Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md * add news for Sweden national resources page --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * New logo and color scheme (#182) * custom theme * test case * more options * more kinds * Update _bootstrap_variables.scss * some more changes * est with arrow * adding arrows * Preview changes tutorial + 'For editors' in sidebar contribute (#171) * preview changes tutorial * add info on how to create a page * Update contribute/preview-changes.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update contribute/preview-changes.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update contribute/preview-changes.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Link to License * change name List of page IDs (#176) * update to snake-case (#175) * Add general introduction for national pages (#147) * Add general introduction for national pages This is modified from the text originally read for Sweden, general agreement from the national resources teams that this would be a good way to introduce the national pages for now. * Remove references to 'recent' Prevent information from becoming too quickly outdated * add info about page aim * Update national-resources/index.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Sweden national page (#150) * Add Swedish national page * minor corrections * correct postcovid name * remove search exclude field * update sidebar * add space Added space between affiliations to match other contributors * Remove access info Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update national-resources/sweden.md * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Update national-resources/sweden.md * add news for Sweden national resources page --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * update version * update with new logo * updated favicon * bigger font * less borders * wide toc * more use of theme colors * better variable use * x-blue topnav * fix * sidebar title * less red * no shadows * new icons * more spacing toc * less bold * less strong * carouse fix * mobile fix * mobile * less * add mediakit * update style guide * sidebar fix * better fix --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Add news article about new design and logo (#184) * article * Update _data/news.yml thanks a lot for the review ! Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> --------- Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> * Add new section icon Human biomolecular data (#186) * add new icon * plain svg * cleanup svg * Add vertical version of logo (#185) * add new logos * typo * more spacing * missing png * better quality * center vertically * Move Galaxy showcase out of sandbox (#180) * Add Galaxy Covid19 showcase * Some more fixes * Add wm75 to contributors * Add Acknowledgments section * Add covid19-galaxy to sidebar * change page id to snake-case * Update ENA logo * Fix Galaxy Europe link :) * Add sponsors section * First round of applying code review suggestions Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Improve presentation of reusability * Update image description according to review comment Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/covid19-galaxy.md * Apply suggestions from code review Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Accept reviewer suggestion for rewrite of paragraph Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/covid19-galaxy.md * Update showcase/covid19-galaxy.md --------- Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> Co-authored-by: Björn Grüning <bjoern@gruenings.eu> * Add Galaxy Showcase news item (#187) * add showcases to index page * fix css showcase * add sliding effect * fix flag opacity * add korogenoest to sidebar * start adding Diana * typo fix korogenoest * add Diana to CONTRIBUTORS.yaml * add affiliations * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com> * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md fixed Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/korogenoest.md fixed Co-authored-by: Diana Pilvar <125961725+diana-pilvar@users.noreply.github.com> * Update showcase/korogenoest.md fixed the text, added details Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/korogenoest.md edited the details about metadata checklist filling Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update korogenoest.md specified Dragen vs Galaxy pipeline usage timeline * Update showcase/korogenoest.md we validated that we did not use the container and edited the text accordingly Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/korogenoest.md mentioned the particular workflows, I am afraid at this stage the workflow hub step is not doable Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/korogenoest.md Changed sponsors to funding Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Update showcase/korogenoest.md * Apply suggestions from code review * Update korogenoest.md editted subheadings * Update korogenoest.md added training to metadata * Apply suggestions from code review * fix github action * Update showcase/korogenoest.md * Add korogenoest to news.yml --------- Co-authored-by: bedroesb <bedro@psb.vib-ugent.be> Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com> Co-authored-by: LianeHughes <liane.hughes@scilifelab.uu.se> Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com> Co-authored-by: Wolfgang Maier <maierw@posteo.de> Co-authored-by: Björn Grüning <bjoern@gruenings.eu> Co-authored-by: Diana Pilvar <125961725+diana-pilvar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rabuono sorry for the delay, but your review is very welcome now.