Skip to content

Update data analysis human biomolecular page #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lauportell merged 6 commits into from
Jul 19, 2023
Merged

Update data analysis human biomolecular page #190

lauportell merged 6 commits into from
Jul 19, 2023

Conversation

@lauportell
Copy link
Contributor

@lauportell lauportell commented May 5, 2023

No description provided.

@lauportell lauportell requested a review from a team as a code owner May 5, 2023 09:28
@lauportell lauportell requested a review from IrisVanDam May 5, 2023 09:28
@lauportell
Copy link
Contributor Author

lauportell commented May 5, 2023

@ainajene @solcos to review and let any editor know so that we can merge

@lauportell
Copy link
Contributor Author

lauportell commented May 5, 2023

Closes #159

@bedroesb bedroesb linked an issue May 5, 2023 that may be closed by this pull request
Data analysis - Human biomolecular data #159
Closed
IrisVanDam
IrisVanDam suggested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@IrisVanDam IrisVanDam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey all,
I just finished reading this page and think that it is really well structured, clear and to the point. Even for someone like me who is not familiar with analysing human biomolecular data :). Congrats on the work you did!
I've left some minor suggestions and comments throughout, but think that this page might be ready to be published very soon.

@lauportell
Copy link
Contributor Author

lauportell commented Jun 28, 2023

Hi Iris, thank you for the comments!
I will let the contributors know about them so that they can address them and we can finalize the page.

solcos added a commit to solcos/infectious-diseases-toolkit that referenced this pull request Jun 28, 2023
@solcos
Update data-analysis.md
cc442b9 
Edit of the suggested changes made in elixir-europe#190
@solcos solcos mentioned this pull request Jun 28, 2023
Merged
@solcos
Update data-analysis.md (#201)
a9f20a5 
Edit of the suggested changes made in #190
@lauportell
Copy link
Contributor Author

lauportell commented Jun 29, 2023

@IrisVanDam some changes were done by Arnau and I think that your comments were addressed :)
Do you want to do a last review before we merge?
Thank you!!

@lauportell lauportell self-assigned this Jun 29, 2023
@bedroesb bedroesb changed the base branch from update-hbd-data-sources to main June 29, 2023 14:39
@bedroesb bedroesb force-pushed the update-hbd-data-analysis branch from 931009a to a9f20a5 Compare June 29, 2023 14:50
@lauportell lauportell requested a review from IrisVanDam June 29, 2023 16:57
@bedroesb bedroesb mentioned this pull request Jun 30, 2023
Merged
@lauportell
Copy link
Contributor Author

lauportell commented Jul 13, 2023

Hi @IrisVanDam :)
Can you do a final review so we can merge this page?
Thank you!

IrisVanDam
IrisVanDam approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@IrisVanDam IrisVanDam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :D!

@lauportell lauportell merged commit 6bb54b2 into main Jul 19, 2023
@lauportell lauportell deleted the update-hbd-data-analysis branch July 19, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IrisVanDam IrisVanDam IrisVanDam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lauportell lauportell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Data analysis - Human biomolecular data

5 participants

@lauportell @IrisVanDam @solcos @bedroesb