-
Notifications
You must be signed in to change notification settings - Fork 42
National resources page for the Netherlands #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added Dutch nation resources page
Update after review
Removed tabs
Updated format
@rnavest thanks a lot for converting all this content to markdown, in my opinion this is in a very good state. @elixir-europe/idtk-editors |
@bedroesb thank you for linking this pull request to the issue and solving the format issues |
…oolkit into pr/rnavest/209
|
me excuses, I just noticed you added them at the bottom of the markdown, I moved them to the contributors file! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments on the national_resources to keep it consistent with other pages.
national-resources/netherlands.md
Outdated
of what is available, allows searching for specific data and makes access | ||
to such data easier when the necessary ethical and legal conditions have | ||
been met. | ||
how_to_access: request data through the dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how_to_access: request data through the dashboard | |
how_to_access: #request data through the dashboard |
Commenting out. The how_to_access
field is generally used to explain access to the resource itself when it is closed/restricted access. But not to the data inside the resource.
I am copy/pasting the same comment to the other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. I've changed it to "the policy for access to and sharing of clinical COVID-19 is described in https://elsi.health-ri.nl/sites/elsi/files/2022-03/HRI_COVID-NL%20policy%20doc%20v2.0%20final.pdf"
Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Changed how_to_access for the COVID-NL clinical data dashboard
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
@rabuono I've made changes to resolve your comments. Could you approve the review so the page could go live? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Thanks!
Related issue: #195