Skip to content

National resources page for the Netherlands - #209

Merged
rabuono merged 26 commits into
elixir-europe:mainfrom
rnavest:patch-1
Aug 8, 2023
Merged

National resources page for the Netherlands#209
rabuono merged 26 commits into
elixir-europe:mainfrom
rnavest:patch-1

Conversation

@rnavest

@rnavest rnavest commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Related issue: #195

rnavest added 5 commits June 27, 2023 09:58
Added Dutch nation resources page
Update after review
Updated format
@rnavest
rnavest requested a review from a team as a code owner July 6, 2023 12:54
@bedroesb bedroesb linked an issue Jul 7, 2023 that may be closed by this pull request
@bedroesb

bedroesb commented Jul 7, 2023

Copy link
Copy Markdown
Member

@rnavest thanks a lot for converting all this content to markdown, in my opinion this is in a very good state. @elixir-europe/idtk-editors

@rnavest

rnavest commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

@bedroesb thank you for linking this pull request to the issue and solving the format issues

@bedroesb
bedroesb self-requested a review as a code owner July 10, 2023 12:24
@bedroesb

bedroesb commented Jul 10, 2023

Copy link
Copy Markdown
Member

@rnavest would it be possible to add yourself at the bottom of this CONTRIBUTORS file? Feel free to choose which information you add!

@bedroesb

Copy link
Copy Markdown
Member

me excuses, I just noticed you added them at the bottom of the markdown, I moved them to the contributors file!

Comment thread national-resources/netherlands.md
Comment thread national-resources/netherlands.md
Comment thread national-resources/netherlands.md Outdated

@rabuono rabuono left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments on the national_resources to keep it consistent with other pages.

Comment thread national-resources/netherlands.md Outdated
Comment thread national-resources/netherlands.md Outdated
of what is available, allows searching for specific data and makes access
to such data easier when the necessary ethical and legal conditions have
been met.
how_to_access: request data through the dashboard

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
how_to_access: request data through the dashboard
how_to_access: #request data through the dashboard

Commenting out. The how_to_access field is generally used to explain access to the resource itself when it is closed/restricted access. But not to the data inside the resource.
I am copy/pasting the same comment to the other

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I've changed it to "the policy for access to and sharing of clinical COVID-19 is described in https://elsi.health-ri.nl/sites/elsi/files/2022-03/HRI_COVID-NL%20policy%20doc%20v2.0%20final.pdf"

Comment thread national-resources/netherlands.md Outdated
Comment thread national-resources/netherlands.md Outdated
Comment thread national-resources/netherlands.md Outdated
Comment thread national-resources/netherlands.md Outdated
Comment thread national-resources/netherlands.md Outdated
rnavest and others added 7 commits July 11, 2023 08:14
Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Changed how_to_access for the COVID-NL clinical data dashboard
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
Co-authored-by: rafael buono <77321541+rabuono@users.noreply.github.com>
@rnavest

rnavest commented Jul 26, 2023

Copy link
Copy Markdown
Contributor Author

@rabuono I've made changes to resolve your comments. Could you approve the review so the page could go live?

@rabuono rabuono left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Thanks!

@rabuono
rabuono merged commit 48e950c into elixir-europe:main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

National resources page for the Netherlands

3 participants