Skip to content

Create new page of image analysis showcase#329

Merged
bedroesb merged 26 commits intomainfrom
image-analysis
Aug 13, 2024
Merged

Create new page of image analysis showcase#329
bedroesb merged 26 commits intomainfrom
image-analysis

Conversation

@lauportell
Copy link
Contributor

Closes #328

@lauportell lauportell requested a review from bedroesb as a code owner July 15, 2024 10:06
@bedroesb
Copy link
Member

General comment:

  • The file is called image_analysis
  • The Title is: Measuring COVID-19 induced neuroinflammation - an automated pipeline for analysing brain autoradiography images
  • the page id is image_analysis_isidore
  • The side bar is most of the time the same is the title, so also: Measuring COVID-19 induced neuroinflammation - an automated pipeline for analysing brain autoradiography images

I feel like we should homogenize these and make the title shorter

image

@bedroesb
Copy link
Member

More information about "Isabel Kemmer" should still be added to the CONTRIBUTORS file

@bedroesb
Copy link
Member

@EvaGarciaAlvarez I did a more general review but did not really read the content :)

Copy link
Contributor

@EvaGarciaAlvarez EvaGarciaAlvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I only have a couple of comments (mainly typos) to address before publishing the page.

@lauportell
Copy link
Contributor Author

Add ISIDORe logo in Affiliations

@lauportell
Copy link
Contributor Author

More information about "Isabel Kemmer" should still be added to the CONTRIBUTORS file

done!

@lauportell
Copy link
Contributor Author

General comment:

  • The file is called image_analysis
  • The Title is: Measuring COVID-19 induced neuroinflammation - an automated pipeline for analysing brain autoradiography images
  • the page id is image_analysis_isidore
  • The side bar is most of the time the same is the title, so also: Measuring COVID-19 induced neuroinflammation - an automated pipeline for analysing brain autoradiography images

I feel like we should homogenize these and make the title shorter

image

done!

@lauportell
Copy link
Contributor Author

Add ISIDORe logo in Affiliations

done!

@lauportell
Copy link
Contributor Author

I think all changes have been addressed, let me know if there's anything else needed

@bedroesb
Copy link
Member

Looks good now!

@bedroesb bedroesb dismissed EvaGarciaAlvarez’s stale review August 13, 2024 17:06

These changes has been implemented

@bedroesb bedroesb merged commit 909d12c into main Aug 13, 2024
@bedroesb bedroesb deleted the image-analysis branch August 13, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New showcase page on image analysis tool

4 participants