Skip to content

Update provenance.md - #77

Merged
stain merged 2 commits into
elixir-europe:mainfrom
RudoWittner:patch-2
Oct 17, 2022
Merged

Update provenance.md#77
stain merged 2 commits into
elixir-europe:mainfrom
RudoWittner:patch-2

Conversation

@RudoWittner

Copy link
Copy Markdown
Contributor

First draft of the provenance page for human clinical and health data.

First draft of the provenance page for human clinical and health data.
@RudoWittner
RudoWittner requested a review from a team as a code owner October 17, 2022 12:54
@stain

stain commented Oct 17, 2022

Copy link
Copy Markdown
Member

This is a good start! Would you mind adding markdown headers, e.g.

# RO Crate

RO Crate is an implementation ..

Instead of textual citations, would you make it into hyperlinks?

[W3C PROV](https://www.w3.org/TR/prov-overview/) is a..

I would do it, but I don't seem to have write-access nor able to approve - perhaps need to be added to elixir-europe/idtk-editors ?
(Edit: I do have review access, just not merge access. Not sure if Rudolf needs to enable access in the PR so I can contribute to the file before it is merged? )

@stain stain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Here are my proposed improvements.

  • Change to inline hyperlinks instead of citations
  • Make # headings
  • Add link to https://w3id.org/ro/crate/1.1 for RO-Crate specifications.
  • Remove [image]... screenshot at end

@stain
stain merged commit 0dd54d9 into elixir-europe:main Oct 17, 2022
@stain stain mentioned this pull request Oct 17, 2022
@bedroesb

bedroesb commented Oct 17, 2022

Copy link
Copy Markdown
Member

@stain and @RudoWittner Maybe it would be nice to explain what provenance means in Human clinical and health data? Also explaining which considerations one needs would be a good thing like proposed here. Now the content feels like a list of things that come a bit out of the blue, no?

@IrisVanDam

Copy link
Copy Markdown
Contributor

Thanks a lot for showing us how to get started with adding information to a page! I think that a short introduction could be really useful explaining why and how it is used in addition to explaining what it means as suggested by Bert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants