Skip to content

Restructure your role pages #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2023
Merged

Restructure your role pages #1350

merged 8 commits into from
Aug 9, 2023

Conversation

bedroesb
Copy link
Member

@bedroesb bedroesb commented Aug 9, 2023

With following rules:

Data steward: policy (page_id: policy_officer) ========> Policy maker
Data steward: research (page_id: it_support) ======> Data Steward
Data steward: infrastructure (page_id: data_manager) ==> RSE

  • Redirects are put in place to the new data steward page
  • Old url links towards these pages have been replaced with the new ones
  • page_ids have been updated to the new ones
  • Sidebar is updated

Do we still need to update something to the contributors?

Martin Cook and others added 6 commits August 9, 2023 15:35
* New PI page for Your role

* New Data Steward page plus tweaks to other role pages

* Removing the PI page to clean PR

* Update data_steward.md

changed wrong Infrastructure DS description

---------

Co-authored-by: wittigue <ulrike.wittig@h-its.org>
new Policy maker role text based on document from contentathon
#1276
* New role page for RSE

* Update research_software_engineer.md

changed two urls

---------

Co-authored-by: wittigue <ulrike.wittig@h-its.org>
@bedroesb
Copy link
Member Author

bedroesb commented Aug 9, 2023

I just realize that if we do not have tools anymore at the bottom of these role pages, that it does not make much sense to still tag national tools with them. I can probably take them all out?

@bedroesb bedroesb requested a review from martin-nc August 9, 2023 14:00
Copy link
Contributor

@martin-nc martin-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I'd say "yes" about the national tools. These role pages are just portal pages now.

This was linked to issues Aug 9, 2023
@bedroesb bedroesb requested a review from floradanna as a code owner August 9, 2023 14:45
@bedroesb bedroesb added topic/YourRole Personas specific issue or PR contentathon Contentathon related issues and PRs labels Aug 9, 2023
@bedroesb
Copy link
Member Author

bedroesb commented Aug 9, 2023

Ok lets merge. These changes have been discussed for a while now!

@bedroesb bedroesb merged commit 260a3e3 into master Aug 9, 2023
@bedroesb bedroesb deleted the role-restructure branch August 9, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contentathon Contentathon related issues and PRs topic/YourRole Personas specific issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Your Roles Pages Feedback on the 'Your role' section
3 participants