Skip to content

Add enzymology domain page - #1614

Merged
bedroesb merged 25 commits into
masterfrom
add-domain-pages
May 13, 2025
Merged

Add enzymology domain page#1614
bedroesb merged 25 commits into
masterfrom
add-domain-pages

Conversation

@bedroesb

@bedroesb bedroesb commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This will close #1013

@bedroesb
bedroesb requested a review from wittigue March 18, 2025 08:12
@bedroesb

bedroesb commented Mar 19, 2025

Copy link
Copy Markdown
Member Author

@wittigue oh I did not expect you to work on my PR, I thought you would merge :)

@wittigue

wittigue commented Mar 19, 2025

Copy link
Copy Markdown
Collaborator

@bedroesb sorry for the confusion :)

bedroesb and others added 3 commits March 20, 2025 08:51
@bedroesb
remove virology placeholder
090851a
@wittigue @github-actions @bedroesb
Update CONTRIBUTORS.yaml (#1616)
c7cfceb 
* Update tool/resource_list.yaml (#1613)

Co-authored-by: bedroesb <bedroesb@users.noreply.github.com>

* Update CONTRIBUTORS.yaml

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bedroesb <bedroesb@users.noreply.github.com>
@wittigue @github-actions @bedroesb
Update tool_and_resource_list.yml (#1617)
24f96e2 
* Update tool/resource_list.yaml (#1613)

Co-authored-by: bedroesb <bedroesb@users.noreply.github.com>

* Update tool_and_resource_list.yml

added tools and resources for the domain page about enzymology and biocatalysis

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bedroesb <bedroesb@users.noreply.github.com>
Co-authored-by: Bert Droesbeke <bertdroesbeke@hotmail.com>
@bedroesb bedroesb changed the title Add placeholder domain pages for virology and enzymology Add enzymology domain page Mar 20, 2025
@bedroesb bedroesb mentioned this pull request Mar 20, 2025
Closed
@bedroesb

bedroesb commented Mar 20, 2025

Copy link
Copy Markdown
Member Author

@wittigue the tool "schemas-org" is not described in the tools and resources list, but is mentioned in the content

@wittigue

wittigue commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

ah, sorry, should be "schema-org"

@bedroesb

bedroesb commented Mar 20, 2025

Copy link
Copy Markdown
Member Author

This will close #1013

@bedroesb

bedroesb commented Mar 20, 2025

Copy link
Copy Markdown
Member Author

@wittigue should be all fixed now!

bianchini88
bianchini88 requested changes Apr 3, 2025
View reviewed changes
Comment thread _data/CONTRIBUTORS.yaml Outdated
Comment thread _data/news.yml Outdated
Comment thread _data/tool_and_resource_list.yml Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
bianchini88 and others added 2 commits April 3, 2025 10:37
@bianchini88
Merge branch 'master' into add-domain-pages
e55b13f
@GilOliveira @bianchini88
Apply suggestions from code review
4cace04 
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
@GilOliveira
GilOliveira requested a review from floradanna as a code owner May 9, 2025 12:19
@bedroesb

bedroesb commented May 9, 2025

Copy link
Copy Markdown
Member Author

@wittigue @bianchini88 @GilOliveira This has to be approved and merged if ready :)

bianchini88
bianchini88 reviewed May 12, 2025
View reviewed changes
Comment thread pages/your_domain/enzymology_and_biocatalysis.md Outdated
bianchini88
bianchini88 reviewed May 12, 2025
View reviewed changes
Comment thread _data/tool_and_resource_list.yml Outdated
@bianchini88

bianchini88 commented May 12, 2025

Copy link
Copy Markdown
Collaborator

This has to be approved and merged if ready :)

Some comments still need to be addressed, e.g. the one on the bibliography entry and the missing tool snippet.
@bedroesb @wittigue

wittigue and others added 5 commits May 12, 2025 16:04
@wittigue @bianchini88
Update _data/tool_and_resource_list.yml
3ea1b4b 
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
@wittigue @bianchini88
Update pages/your_domain/enzymology_and_biocatalysis.md
0980c07 
Co-authored-by: Federico Bianchini <72258479+bianchini88@users.noreply.github.com>
@wittigue
Update enzymology_and_biocatalysis.md
b80d0f2
@wittigue
Update enzymology_and_biocatalysis.md
cc41b44 
add STRENDA as tool
@wittigue
Update tool_and_resource_list.yml
81b0cff 
Add STRENDA fairsharing link
@bedroesb

bedroesb commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

https://github.com/elixir-europe/rdmkit/blob/add-domain-pages/_bibliography/references.bib File for the bibliography to be updated

wittigue added 2 commits May 13, 2025 10:21
@wittigue
Update references.bib
d9a54fa 
Add reference about enzyme databases
@wittigue
Update enzymology_and_biocatalysis.md
cb8f80a 
Add bibliopraphy
@wittigue

wittigue commented May 13, 2025

Copy link
Copy Markdown
Collaborator

@bedroesb could you please check the author names in the citation if they are represented correctly?

@bianchini88

bianchini88 commented May 13, 2025

Copy link
Copy Markdown
Collaborator

image

@wittigue, that's how the bibliography looks on a local deployment.

@bedroesb Did we decide where to place the citations in the running text? Here, the number comes after a full stop, whilst in the machine learning page, the numbers come before the full stop.

@bedroesb

bedroesb commented May 13, 2025

Copy link
Copy Markdown
Member Author

@bianchini88 I don't think we ever did. Preference?

@wittigue

wittigue commented May 13, 2025

Copy link
Copy Markdown
Collaborator

Other pages have it before the stop. So I would suggest to use that also here.

@wittigue
Update enzymology_and_biocatalysis.md
67b51f3 
Changed position for citation
@bianchini88
bianchini88 self-requested a review May 13, 2025 13:13
@bedroesb
bedroesb merged commit aaa9a39 into master May 13, 2025
@bedroesb
bedroesb deleted the add-domain-pages branch May 13, 2025 13:26
@bedroesb bedroesb mentioned this pull request Mar 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wittigue wittigue wittigue approved these changes
@bianchini88 bianchini88 bianchini88 approved these changes
@GilOliveira GilOliveira Awaiting requested review from GilOliveira GilOliveira is a code owner
@floradanna floradanna Awaiting requested review from floradanna floradanna is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New domain page about Enzymology

4 participants

@bedroesb @wittigue @bianchini88 @GilOliveira