-
Notifications
You must be signed in to change notification settings - Fork 137
Bioimaging Domain #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bioimaging Domain #765
Conversation
@jburel Good point about the tables, I fixed this in my last commit: https://rdmkit.elixir-europe.org/markdown_cheat_sheet.html#tables (if you empty your cash it should be better) |
@jburel could you please add me as a reviewer? |
@bedroesb could you remind me the link to the g.doc to update the list of contributors? or updating the yaml file is enough |
@jburel The yaml file is enough! (even if you don't add them there they will show up, but it is nice you added some metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jburel I wonder if we should add bioimaging data
id to the tools discussed on this page in the toolstable
@korbinib and @floradanna what are your opinion on this?
@bedroesb That will make sense edit: Question, can the entries have more than one tag since for example IDR has already the ome tag? |
Sure!, it is a comma separated list |
The easiest is to add them to this spreadsheet this way it always stays up to date, or you add them to the csv and the spreadsheet, if you feel adventurous :) |
@bedroesb I have updated the spreadsheet with the new tag and added new entries |
@jburel yaml was not needed since that is overwritten automatically, but thanks anyway ! |
hmm I have to check the toolstable first since there seems to be an error |
I think the csv is manually updated and at some rows the the last column got lost, I will overwrite with the one from the google spreadsheet |
@jburel can you check if every tool is still correctly tagged? In general we recommend people to just add it to the google spreadsheet so they don't have to manipulate our monster csv 🥲 |
@bedroesb Thanks. It still looks good. |
@smza Anything else needed for now? I think we will add other sections on analysis and possibly expand the metadata section in follow-up PRs |
Hi @jburel, I have reorganised your content with additional feedback from another editor (Flora). I'll share that with you for your comments and approval later today. |
Thanks |
Hi @jburel here is the link to the reorganised and edited content: https://docs.google.com/document/d/1UfNW6aqzC5nzwHgjCHbEQDLgRsZOrQHFcTfkCNBbyu4/edit?usp=sharing We've made some major changes which would be complicated to see in PR. Please have a look and see if you agree with and let us know if you have any questions or need a discussion. |
Thanks for the comments. I will have a look. I tried the table layout previously but it renders poorly. |
Hi @jburel , You can either copy the content from google doc and add it to your fork and then merge OR just add comments to google doc and I'll merge it after that. Thanks, |
Co-authored-by: Sébastien Besson <seb.besson@gmail.com>
Co-authored-by: Sébastien Besson <seb.besson@gmail.com>
Co-authored-by: Sébastien Besson <seb.besson@gmail.com>
I have removed the changes in the CVS to avoid constant conflicts |
@smza I have adjusted the content in this PR to match the suggestions made in the g.doc. |
Thanks. I'll have a look at it. Yes from now on any comments will only be on the PR. |
Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
@jburel I've approved and merged the PR. |
@smza Thanks |
Add new entry for bioimaging domain
@bedroesb I wanted to use markdown table but the rendering is not great, hard to see difference between the columns
and the rows are of the same color so I opted for a long list
suggestion welcome
cc @joshmoore, @sbesson @sukunis @smza