Skip to content

Bioimaging Domain #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 14, 2021
Merged

Bioimaging Domain #765

merged 19 commits into from
Dec 14, 2021

Conversation

jburel
Copy link
Contributor

@jburel jburel commented Nov 22, 2021

Add new entry for bioimaging domain

@bedroesb I wanted to use markdown table but the rendering is not great, hard to see difference between the columns
and the rows are of the same color so I opted for a long list
suggestion welcome

cc @joshmoore, @sbesson @sukunis @smza

@bedroesb
Copy link
Member

@jburel Good point about the tables, I fixed this in my last commit: https://rdmkit.elixir-europe.org/markdown_cheat_sheet.html#tables (if you empty your cash it should be better)

@smza
Copy link
Collaborator

smza commented Nov 23, 2021

@jburel could you please add me as a reviewer?

@bedroesb bedroesb requested a review from smza November 23, 2021 10:26
@jburel
Copy link
Contributor Author

jburel commented Nov 23, 2021

@bedroesb could you remind me the link to the g.doc to update the list of contributors? or updating the yaml file is enough

@bedroesb
Copy link
Member

@jburel The yaml file is enough! (even if you don't add them there they will show up, but it is nice you added some metadata)

@jburel jburel mentioned this pull request Nov 23, 2021
@bedroesb bedroesb linked an issue Nov 23, 2021 that may be closed by this pull request
@jburel jburel changed the title WIP: Bioimaging Domain Bioimaging Domain Nov 24, 2021
Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jburel I wonder if we should add bioimaging data id to the tools discussed on this page in the toolstable

@korbinib and @floradanna what are your opinion on this?

@jburel
Copy link
Contributor Author

jburel commented Nov 26, 2021

@bedroesb That will make sense

edit: Question, can the entries have more than one tag since for example IDR has already the ome tag?

@bedroesb
Copy link
Member

Sure!, it is a comma separated list

@bedroesb
Copy link
Member

The easiest is to add them to this spreadsheet this way it always stays up to date, or you add them to the csv and the spreadsheet, if you feel adventurous :)

@jburel jburel requested a review from wittigue as a code owner December 2, 2021 12:47
@jburel
Copy link
Contributor Author

jburel commented Dec 2, 2021

@bedroesb I have updated the spreadsheet with the new tag and added new entries
I have also updated the CVS file and the yml file in this PR (this might explain the failure)

@bedroesb
Copy link
Member

bedroesb commented Dec 2, 2021

@jburel yaml was not needed since that is overwritten automatically, but thanks anyway !

@bedroesb
Copy link
Member

bedroesb commented Dec 2, 2021

hmm I have to check the toolstable first since there seems to be an error

@bedroesb
Copy link
Member

bedroesb commented Dec 2, 2021

I think the csv is manually updated and at some rows the the last column got lost, I will overwrite with the one from the google spreadsheet

@bedroesb
Copy link
Member

bedroesb commented Dec 2, 2021

@jburel can you check if every tool is still correctly tagged? In general we recommend people to just add it to the google spreadsheet so they don't have to manipulate our monster csv 🥲

@jburel
Copy link
Contributor Author

jburel commented Dec 2, 2021

@bedroesb Thanks. It still looks good.

@jburel
Copy link
Contributor Author

jburel commented Dec 10, 2021

@smza Anything else needed for now? I think we will add other sections on analysis and possibly expand the metadata section in follow-up PRs

@smza
Copy link
Collaborator

smza commented Dec 10, 2021

@smza Anything else needed for now? I think we will add other sections on analysis and possibly expand the metadata section in follow-up PRs

Hi @jburel, I have reorganised your content with additional feedback from another editor (Flora). I'll share that with you for your comments and approval later today.

@jburel
Copy link
Contributor Author

jburel commented Dec 10, 2021

Thanks

@smza
Copy link
Collaborator

smza commented Dec 10, 2021

@smza Anything else needed for now? I think we will add other sections on analysis and possibly expand the metadata section in follow-up PRs

Hi @jburel, I have reorganised your content with additional feedback from another editor (Flora). I'll share that with you for your comments and approval later today.

Hi @jburel here is the link to the reorganised and edited content: https://docs.google.com/document/d/1UfNW6aqzC5nzwHgjCHbEQDLgRsZOrQHFcTfkCNBbyu4/edit?usp=sharing

We've made some major changes which would be complicated to see in PR. Please have a look and see if you agree with and let us know if you have any questions or need a discussion.

@jburel
Copy link
Contributor Author

jburel commented Dec 13, 2021

Thanks for the comments. I will have a look. I tried the table layout previously but it renders poorly.
How to you want to move forward? Review in the g.doc since I do not want to spend time moving between markdown and g.doc constantly

@smza
Copy link
Collaborator

smza commented Dec 13, 2021

Thanks for the comments. I will have a look. I tried the table layout previously but it renders poorly.
How to you want to move forward? Review in the g.doc since I do not want to spend time moving between markdown and g.doc constantly

Hi @jburel ,
I had to share the google doc because Github would not allow markdown as attachment and I couldn’t create a branch on your fork. Since there was considerable reorganisation it would be difficult to follow if I edited your current md. I had discussed this with Bert and we couldn’t figure out any other way.

You can either copy the content from google doc and add it to your fork and then merge OR just add comments to google doc and I'll merge it after that.

Thanks,
Munazah

@jburel
Copy link
Contributor Author

jburel commented Dec 14, 2021

I have removed the changes in the CVS to avoid constant conflicts

@jburel
Copy link
Contributor Author

jburel commented Dec 14, 2021

@smza I have adjusted the content in this PR to match the suggestions made in the g.doc.
If any more comments, will it possible to make them on the PR itself? This will simplify things for me. Thanks.

@smza
Copy link
Collaborator

smza commented Dec 14, 2021

@smza I have adjusted the content in this PR to match the suggestions made in the g.doc.
If any more comments, will it possible to make them on the PR itself? This will simplify things for me. Thanks.

Thanks. I'll have a look at it. Yes from now on any comments will only be on the PR.

jburel and others added 3 commits December 14, 2021 14:07
Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
@smza smza merged commit 25ed80b into elixir-europe:master Dec 14, 2021
@smza
Copy link
Collaborator

smza commented Dec 14, 2021

@jburel I've approved and merged the PR.

@jburel
Copy link
Contributor Author

jburel commented Dec 15, 2021

@smza Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BioImaging data
4 participants