Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update se_national_resources.md #827

Merged
merged 12 commits into from
Feb 11, 2022

Conversation

YvonneKallberg
Copy link
Contributor

Initial version, not yet final so should not be visible on RDMkit yet

Initial version, not yet final
Cleaning up resources metadata in header
Further cleanup of resources metadata, removing comments
Update after feedback, splitting authorities and regulations into separate sections, and adding some links to infrastructures, among other things
Final version, removed search exclude
@YvonneKallberg
Copy link
Contributor Author

Build failed, do not know why, but otherwise we are ready for review and publish

@bedroesb
Copy link
Member

@YvonneKallberg everything looks fine, so I think it is an error on our side. We recently moved the backbone of RDMkit and because of that I had to add some checks, let me try to recreate the problem and get back to you! Sorry for this inconvenience

@lauportell
Copy link
Collaborator

Hi @YvonneKallberg !
All mistakes were corrected and now it is buidling :)
Everything looks good so I will merge the PR.

@lauportell lauportell merged commit 9a462ff into elixir-europe:master Feb 11, 2022
@bedroesb
Copy link
Member

bedroesb commented Feb 11, 2022

It was a combination of a bug on our side where related pages has to be present at a tool (good that you stumbled on this bug!) and we noticed that not all page_id s were correct. A tip to find the correct page ID of a page when listing is this page. Thanks for your contribution!

@bedroesb bedroesb linked an issue Feb 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

National resources page Sweden
3 participants