Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Page: Data Brokering #892

Merged
merged 25 commits into from
Jun 13, 2022
Merged

Task Page: Data Brokering #892

merged 25 commits into from
Jun 13, 2022

Conversation

Nazeeefa
Copy link
Collaborator

Data Brokering
New task page, by ELIXIR Converge WP9 team, that addresses how to get started as a data broker; how data and metadata collection and sharing should be done. The page covers key considerations, and provides solutions and recommendations that could help with how to share data within a well defined ethical and legal framework.

Are there existing pages in the RDMkit website related to the requested page?
The 'Data Brokering' task page can be added under "related pages" in the following page: Your Role - Data Steward: infrastructure

Data Brokering - task page, version 1
Data brokering workflow image (in svg format) added
@bedroesb
Copy link
Member

Hey Nazeefa! I changed the image filename so it does not contain (1) + updated the image syntax to be markdown.

removed dsw tag and added figure title
@bedroesb
Copy link
Member

https://rdmkit.elixir-europe.org/markdown_cheat_sheet#images the theme also allows to use the include image hat has the build in caption capability, but I should give the option to cutomize the width

Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated some urls since it is advised to not use absolute linking towards internal pages (this way we are not sensitive to domain changes). I see you refer to multiple resources that are already in the tools table, could you at the data brokering tag to the spreadsheet of tools?

pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
@bedroesb
Copy link
Member

Some information about descriptive URLs

Nazeeefa and others added 12 commits April 28, 2022 09:38
Updated URLs of internal pages

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of internal page on DMP

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of data protection (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of data collection (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of data quality (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of data transfer (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of data analysis (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of Data storage (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Update URL of data publication (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Replacing plain URLs of sensitive data and human data (RDMkit) pages

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Replace plain URL of Data storage (RDMkit) page

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
Replace plain URL for ENA with a text and hyperlink

Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
@floradanna
Copy link
Collaborator

@Nazeeefa Thanks for this contribution.

I would suggest to improve a bit the image:

  • What are the empty squares with dark blue frame? Can this be made more clear in the image?
  • Some icons have thicker then other. Could it be possible to you use icons more similar to each other?
  • What is the rectangle with light blue frame? Does it represent also data providers? Could you make it more explicit please in the image.
  • The light blue color is not very visible, maybe a color with more contrast?
  • Could the arrows have the same color of the "origin" ? It would be easier to follow. See example below.
  • Only Covid19 portal, GISAID and health authorities are present in the image. In my opinion, it gives the impression that this model only apply to health related domain. Maybe we could simply write "Local and international repositories" and then list few as examples. Also, Covid19 portal might not be the best example, since data are actually submitted to ENA, PRIDE, ArrayExpress etc... and only indexed by the portal.
  • Is "authorities" in the caption the correct word? Maybe National health databases?
  • The credits/licence of the icons could be written as separated paragraph under the caption or in smaller case/different font. I don't know. @bedroesb @martin-nc what do you think?

Screenshot 2022-04-28 at 12 13 24

@aitananeves
Copy link

thank you @Nazeeefa and @martin-nc all good with me with your caption suggestions, thanks!

@Nazeeefa
Copy link
Collaborator Author

@martin-nc Kindly let me know once the latest version of figure is available and feel free to update/replace the caption based on our suggested changes, or let me know and I can do it. Thank you for your time.

@martin-nc
Copy link
Member

@Nazeeefa Sorry - I wasn't sure if I was supposed to do the diagram! What about this (not glamorous but it's at least in the brand colours and font!):

data-brokerage

@martin-nc
Copy link
Member

Alternative version. I think we could add icons to this, too, if desired:

Asset 6

@Nazeeefa
Copy link
Collaborator Author

Thank you so much @martin-nc I am happy with both versions, wondering if @alebrand prefers second one and want to add icons to it? :)

Apparently, I am unable to figure out how to upload the figure to this PR. Kindly upload whichever one is preferred by @alebrand or let me know and I'll figure out.

@aitananeves
Copy link

Dear all, thanks a lot, I think I prefer the first version with blank fills. Fine to go like this without icons, it makes the message more clear perhaps. Thank you very much for everything and for branding it!

@Nazeeefa
Copy link
Collaborator Author

Nazeeefa commented Jun 6, 2022

Hi @floradanna, and @bedroesb: is it ok to merge this now? :)

@floradanna
Copy link
Collaborator

@Nazeeefa I have few comments on the text, I don't know if you have seen them. It would be better if you could address them, please.

@Nazeeefa
Copy link
Collaborator Author

Nazeeefa commented Jun 7, 2022

@floradanna I think all your comments are addressed, kindly let me know if anything was missed. Thank you for your time and help.

pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
pages/your_tasks/data_brokering.md Outdated Show resolved Hide resolved
@floradanna
Copy link
Collaborator

@Nazeeefa I had added comments but I didn't submit my review, so it was not visible to you but I didn't realise it before. Sorry about that. I have just now submitted my comments and you should be able to see them. In general, I would suggest to provide possible criteria to find solutions related to the listed considerations (see specific line above) and try to make the text a bit more generic and less ENA-centric (see specific comment above).

Sorry again for the misunderstanding.

Updated links and fixed text, mainly 'Sharing data to public repositories' section
@floradanna
Copy link
Collaborator

@Nazeeefa thank you.
Please, make sure that:

Updated name and added description
@floradanna
Copy link
Collaborator

@Nazeeefa you can merge! :)

@aitananeves
Copy link

thanks a lot everyone!

@bedroesb
Copy link
Member

wait, is this done? :)

@bedroesb
Copy link
Member

we can also do it afterwards off course

@Nazeeefa
Copy link
Collaborator Author

Nazeeefa commented Jun 13, 2022

wait, is this done? :)

Update: @bedroesb all three suggestions are now addressed :)

@bedroesb
Copy link
Member

oh I see you did it outside this Pull request, next time it is cleaner to add the tags in the same PR, because now there are tags on those pages about a page that does not yet exist :)

@bedroesb bedroesb merged commit 6af0631 into elixir-europe:master Jun 13, 2022
@bedroesb
Copy link
Member

I will add the brokering tools too now :)

@Nazeeefa
Copy link
Collaborator Author

I noticed two of the links to ENA documentation were not working so I just updated with a few more changes (directly via GitHub) - hope that's fine?

@bedroesb
Copy link
Member

Sure, this is post merge ;)

@Nazeeefa
Copy link
Collaborator Author

Nazeeefa commented Dec 8, 2022

Hi @martin-nc, is it possible to make a tiny update to the figure? Apparently, the blue colour used for the figure (#3d68b0) is different from the one recommended by style guide (#376AC3). Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants