Skip to content

Add Galaxy as Tool assembly#961

Merged
korbinib merged 10 commits intoelixir-europe:masterfrom
beatrizserrano:add-galaxy
Aug 26, 2022
Merged

Add Galaxy as Tool assembly#961
korbinib merged 10 commits intoelixir-europe:masterfrom
beatrizserrano:add-galaxy

Conversation

@beatrizserrano
Copy link
Copy Markdown
Contributor

Hi all,

As discussed during the BH2021 (long time ago 😅) this PR is to add the first basic page for Galaxy as Tool assembly. We have created an image with all the solutions that Galaxy provides across the data life cycle using the default from the RDMkit adding the Galaxy logo. We will also present this in a poster at ECCB2022 in September. Can we use the image of the life cycle in general?

Thank you!

cc @bgruening

@bedroesb
Copy link
Copy Markdown
Member

bedroesb commented Aug 1, 2022

@beatrizserrano I love the design of the image! Looks really pro. Little feedback: I don't know if I can figure out only based on the image why one step is with a dotted line, and the Plan step in white (inverted).

PS Yes you can reuse it, we do like though if you add somewhere our little logo https://rdmkit.elixir-europe.org/media_kit (it can also be just the R :)

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

Thanks @bedroesb! I've added the logos to the center of the image.

I don't know if I can figure out only based on the image why one step is with a dotted line, and the Plan step in white (inverted).

We've removed the dotted line. The Plan step is inverted because Galaxy doesn't offer any feature for that. If you think it's still confusing, I can leave the original orange :)

@bedroesb
Copy link
Copy Markdown
Member

bedroesb commented Aug 1, 2022

Well I like the idea of making it different from the others, but I don't know if inverting it is the nicest, I was playing around with some other ways:
galaxy-rdmkite
galaxy-rdmkit2

But I don't know if I like them more, @martin-nc, @korbinib if you have time, could you give your opinion on this :)

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

grey looks nice to me :)

@martin-nc
Copy link
Copy Markdown
Contributor

Since Bert has called me in, I'll give a comment, but feel free to ignore!

  1. What's the purpose of the illustration? If it's to give a brief overview of how Galaxy can help you through the data life cycle, then I think there's too much text. If it's to give more details, then maybe an illustration isn't the best way to convey this information?
  2. How important is the text? If it's important then I guess it should be in HTML rather than an image, so it can be read by search engines and assistive devices, and it is easier to read on small screens.

If the answer to 1 is "A brief summary", I'd do something simpler like this:

RDMlife cycle

I've only done three sections, but hopefully you'll get the gist.

Or you could think mobile-first and do a title like "How Galaxy helps you through the stages of the RDM life cycle", then have tiles instead. These would form columns on wider screens:

RDMlife tiles

If the details are important, then the tiles can be extended, and again form columns on wider screens:

Extended tiles

Anyway those are just some ideas.

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

Thank you @martin-nc, the accessibility is a very valuable point. I like the last version that you presented, the tile including the details. Do you have an example for me to get some inspiration on how to implement this idea?

@martin-nc
Copy link
Copy Markdown
Contributor

@beatrizserrano maybe I was getting too creative there, because it's not something we can do simply in markdown! If you're okay fiddling with Bootstrap classes, though, then something like this:

<div class="container-fluid g-0 my-2">
    <div class="row row-cols-1 row-cols-md-3">
        <div class="col">
            <div class="card border border-2">
                <div class="card-body px-4">
                    <h3 class="card-title text-center mb-4 mt-3">Collect</h3>
                    <h4>Access to databases</h4>
                    <ul class="lh-sm">
                        <li>UNIPROT</li>
                        <li>INTERMINE</li>
                        <li>...</li>
                    </ul>
                    <h4>Customised data access</h4>
                    <ul class="lh-sm">
                        <li>Text 1</li>
                        <li>Text 2</li>
                    </ul>
                    <h4>LIMS integration</h4>
                    <ul class="lh-sm">
                        <li>Text 1</li>
                        <li>Text 2</li>
                    </ul>
                </div>
            </div>
        </div>
        <div class="col">
            <div class="card border border-2">
                <div class="card-body px-4">
                    <h3 class="card-title text-center mb-4 mt-3">Process</h3>
                    <h4>Data transformation</h4>
                    <ul class="lh-sm">
                        <li>UNIPROT</li>
                        <li>INTERMINE</li>
                        <li>...</li>
                    </ul>
                    <h4>Import workflows</h4>
                    <ul class="lh-sm">
                        <li>Text 1</li>
                        <li>Text 2</li>
                    </ul>
                    <h4>Metadata handling</h4>
                    <ul class="lh-sm">
                        <li>Text 1</li>
                        <li>Text 2</li>
                    </ul>
                </div>
            </div>
        </div>
        <div class="col">
            <div class="card border border-2">
                <div class="card-body px-4">
                    <h3 class="card-title text-center mb-4 mt-3">Analyse</h3>
                    <ul>
                        <li>A bit of blurb.</li>
                    </ul>
                </div>
            </div>
        </div>
    </div>
</div>

Should produce something like this:
Screenshot 2022-08-10 at 17 53 05

@bedroesb can confirm, but I don't think we have an easy way to add the life cycle colours. We'd have to create some custom classes, or maybe it's enough to add the icon of the right colour with the header. We have the icons around somewhere.

If this seems a faff, though, then I'd just go with the original diagram. Maybe just have a caption with more explanatory text for SEO/accessibility.

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

I'll give it a try and we compare which version looks nicer :) thanks @martin-nc

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

This is the best that I could do, used background colours with some transparency:

image

Not crucial details, but I see a couple of improvements:

  • I didn't manage to have rounded corners, any suggestions on how to do that?
  • It would be nice to add the icons. I see that they are here. How do I add them?

@martin-nc
Copy link
Copy Markdown
Contributor

For the rounded corners, I think you can just use the rounded class on the card: <div class="card mb-4 rounded">.

I'm not sure about the tinted backgrounds: is there enough contrast ratio between the text and background? https://webaim.org/resources/contrastchecker/. That's why I suggested the border and outline being in colour and the background white. The white background is usually a bit safer for contrast and for colour blind users, but maybe it's okay.

As for the icons, here are some you can put in the images directory to experiment with: life-cycle-icons.zip.

There are many ways to include the images. Maybe it's simplest to include them like a normal image:

<div class="card-body px-4" style="background-color: #fac54b45">
 <div class="w-25 mx-auto"><img src="/images/life-cycle-icons/collect-icon.svg" alt="" /></div>
          <h3 class="card-title text-center mb-4 mt-3">Collect</h3>

The icon is purely decorative so I've left the alt attribute empty.

Maybe @bedroesb has thoughts on this, though, since he's more familiar with the site code. Also, @korbinib for the format of the tool assembly pages.

@bedroesb
Copy link
Copy Markdown
Member

@beatrizserrano and @martin-nc I took the freedom to update a little bit the html code :) Following the suggested syntax from bootstrap for grid cards, you can get rid of many padding and margin classes + it is rounded by default, in the the card class. I also updated you branch with the remote because it was a little bit lagging behind ;) We for example took away the audience attribute etc. I will try to add the icons and have a look!
Screenshot from 2022-08-22 11-16-27

@bedroesb
Copy link
Copy Markdown
Member

@beatrizserrano and @martin-nc, this is with the icons in black:
Screenshot from 2022-08-22 13-28-29

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

Nice! I like the icons. Maybe the card header (where the icon and the title are) could have the background colour. Or would it make it less accessible?

@bedroesb
Copy link
Copy Markdown
Member

If I understood correctly:
Screenshot from 2022-08-22 16-31-06
Screenshot from 2022-08-22 16-24-43

@beatrizserrano
Copy link
Copy Markdown
Contributor Author

Looks great to me. The first version better? What do people think?

@bgruening
Copy link
Copy Markdown

I like the version with the stronger colors and white icons a bit more :)

@bedroesb
Copy link
Copy Markdown
Member

ok done!
Screenshot from 2022-08-23 10-14-10

@elixir-europe/rdmkit-editors what are your opinions?

@bgruening
Copy link
Copy Markdown

Cool, very nice! Thanks, everyone for working on this!

<h4>Metadata handling</h4>
<ul class="lh-sm">
<li>Provenance tracking</li>
<li>Automatic metadata enrichment</li>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this could be more extensive

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beatrizserrano any comments?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much from my side, I think. I don't know if there's something generic enough to be specified here, what do you think @bgruening?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korbinib if @bgruening gives green light, and you give your approval, you can merge. I am on holiday tomorrow :)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add here more (like datatypes, EDAM annotaitons, number of columns, reference genome ...), the question is just if it's worth it and how. I guess for the first PR this is good and we keep adding things to those list later. 👍 from my side. Lets get it in :)

Copy link
Copy Markdown
Collaborator

@korbinib korbinib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check about the EC logo vs EU flag?

@bedroesb
Copy link
Copy Markdown
Member

@korbinib the EC logo was already in place, so I think at one point I wanted to use that one :)

@korbinib korbinib merged commit f5ccf31 into elixir-europe:master Aug 26, 2022
@beatrizserrano beatrizserrano deleted the add-galaxy branch August 26, 2022 12:13
@beatrizserrano
Copy link
Copy Markdown
Contributor Author

Thank you all for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants