Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plant phenomics assembly #985

Merged
merged 16 commits into from
Sep 25, 2022

Conversation

erlefloch
Copy link
Contributor

Hi,
This is a first version of a plant phenomics assembly page, made thanks to the contributors presenting the different tools.
I would like to talk about it at IPPS next week.
Feel free to edit or comment,
Cheers
Erwan

Copy link
Member

@bedroesb bedroesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first attempt!

General comment: internal RDMkit pages are linked to by just using the page name as you will see in my suggestions. Can you also look into tagging the tools you mention in the page with the page_id you propose here

pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
@bedroesb
Copy link
Member

PIPPA btw is part of the Belgian page and should get tagged in the front matter of the national markdown, I don't know for PHIS ;)

erlefloch and others added 2 commits September 22, 2022 14:58
Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
pages/tool_assembly/plant_phenomics_assembly.md Outdated Show resolved Hide resolved
erlefloch and others added 7 commits September 22, 2022 16:26
applying comments from the review
Co-authored-by: Korbinian Bösl <korbinian.bosl@uib.no>
remove redundant TeSS link
update related pages and training in TeSS
simplified the "who is it for" part
@erlefloch
Copy link
Contributor Author

PIPPA btw is part of the Belgian page and should get tagged in the front matter of the national markdown, I don't know for PHIS ;)

do you mean, PHIS should be added to the tools and resources section on the French page ?

@erlefloch
Copy link
Contributor Author

Thanks for your feedback @bedroesb and @korbinib !
I modified the text accordingly. I also updated the tool_and_resource_list sheet, and I added the info to link to MIAPPE training material in TeSS.

first version of a diagram for the plant phenomics assembly
@bedroesb
Copy link
Member

PIPPA btw is part of the Belgian page and should get tagged in the front matter of the national markdown, I don't know for PHIS ;)

do you mean, PHIS should be added to the tools and resources section on the French page ?

If not already done, yes! :)

added FAIDARE
@erlefloch erlefloch requested review from bedroesb and removed request for Nazeeefa, bianchini88 and lauportell September 23, 2022 10:18
@erlefloch erlefloch requested review from korbinib and bedroesb and removed request for bedroesb and korbinib September 23, 2022 10:18
@erlefloch
Copy link
Contributor Author

hi everyone, sorry I messed up the review requests by clicking everywhere, sorry and don't pay attention :)

@bedroesb
Copy link
Member

@erlefloch is PHIS not build to serve the French institutes like PIPPA, or am I wrong? Otherwise I would move it out of the main tools table to the country page metadata instead of linking towards it.

@bedroesb
Copy link
Member

I also took PIPA out of the main tools table since it is already described on our national page

@erlefloch
Copy link
Contributor Author

@erlefloch is PHIS not build to serve the French institutes like PIPPA, or am I wrong? Otherwise I would move it out of the main tools table to the country page metadata instead of linking towards it.

From what I understood, PHIS is the name of both the software and of an instance of it. The software itself can be deployed anywhere, for example I've seen recently here that it was in use in Netherlands

@bedroesb
Copy link
Member

@erlefloch ok fair enough! For me it looks good now.

@bedroesb
Copy link
Member

@korbinib This page would be presented this Monday and it would be nice if a first version could be merged. I don't know If you think your comments got implemented and this disserves your approval ? :) Later on you might want to apply your tricks to include the font in the SVG

@bedroesb
Copy link
Member

bedroesb commented Sep 24, 2022

@erlefloch I just clicked on the GitHub icon on the PHIS website, and it goes to Open SILEX. Maybe PHIS is a deployment of OpenSIlex? That one for sure seems to disserve a spot in the main tools table.

@korbinib korbinib merged commit 68aadff into elixir-europe:master Sep 25, 2022
@korbinib
Copy link
Collaborator

@bedroesb @erlefloch Thank you!

@erlefloch erlefloch deleted the plant-phenomics-assembly branch September 25, 2022 20:30
@erlefloch
Copy link
Contributor Author

@erlefloch I just clicked on the GitHub icon on the PHIS website, and it goes to Open SILEX. Maybe PHIS is a deployment of OpenSIlex? That one for sure seems to disserve a spot in the main tools table.

Yes probably ! @cpommier what was the relationship between OpenSILEX and PHIS again ?

@bedroesb
Copy link
Member

I am intrested in the answer for sure ;) Will upload the tools to RDMkit as they are now

@cpommier
Copy link
Member

HI, sorry for the delayed answer and thanks a lot for your high activity :)
Opensilex is the basis software, that can be implemented in several flavors: PHIS, SIXTINE, VitisOno, etc...
Then each of those flavors are deployed on different sites.
PHIS is a flavor dedicated to high throughput phenotyping, like PIPPA, but is getting used beyond France.
If I understand the logic well, we should put forward PHIS in the general tools section as it goes beyond France. Linking this to phis website, that links to opensilex github, seems ok to me. @Isabelle-inrae could you confirm that this is fine with you ?

@cpommier
Copy link
Member

This has ben merged ? It is therefore live now ?

@bedroesb
Copy link
Member

@cpommier when #994 is merged it will be live in the way you described! I just wonder if it wis worthed to mention Opensilex somewhere on RDMkit. I never heard of it.

@cpommier
Copy link
Member

Thanks @bedroesb , I saw the tool assembly online :) !
I would go toward putting forward PHIS rather than OpenSilex to avoid confusion. But that's @Isabelle-inrae call.

@Isabelle-inrae
Copy link
Contributor

Hi @bedroesb, I confirm @cpommier answer; I think it's better to put PHIS forward! Thanks

@bedroesb
Copy link
Member

Thanks for responding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants