-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plant phenomics assembly #985
Plant phenomics assembly #985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first attempt!
General comment: internal RDMkit pages are linked to by just using the page name as you will see in my suggestions. Can you also look into tagging the tools you mention in the page with the page_id you propose here
PIPPA btw is part of the Belgian page and should get tagged in the front matter of the national markdown, I don't know for PHIS ;) |
Co-authored-by: Bert Droesbeke <44875756+bedroesb@users.noreply.github.com>
applying comments from the review
Co-authored-by: Korbinian Bösl <korbinian.bosl@uib.no>
remove redundant TeSS link
update related pages and training in TeSS
simplified the "who is it for" part
do you mean, PHIS should be added to the tools and resources section on the French page ? |
first version of a diagram for the plant phenomics assembly
If not already done, yes! :) |
added FAIDARE
hi everyone, sorry I messed up the review requests by clicking everywhere, sorry and don't pay attention :) |
@erlefloch is PHIS not build to serve the French institutes like PIPPA, or am I wrong? Otherwise I would move it out of the main tools table to the country page metadata instead of linking towards it. |
I also took PIPA out of the main tools table since it is already described on our national page |
From what I understood, PHIS is the name of both the software and of an instance of it. The software itself can be deployed anywhere, for example I've seen recently here that it was in use in Netherlands |
@erlefloch ok fair enough! For me it looks good now. |
@korbinib This page would be presented this Monday and it would be nice if a first version could be merged. I don't know If you think your comments got implemented and this disserves your approval ? :) Later on you might want to apply your tricks to include the font in the SVG |
@erlefloch I just clicked on the GitHub icon on the PHIS website, and it goes to Open SILEX. Maybe PHIS is a deployment of OpenSIlex? That one for sure seems to disserve a spot in the main tools table. |
@bedroesb @erlefloch Thank you! |
Yes probably ! @cpommier what was the relationship between OpenSILEX and PHIS again ? |
I am intrested in the answer for sure ;) Will upload the tools to RDMkit as they are now |
HI, sorry for the delayed answer and thanks a lot for your high activity :) |
This has ben merged ? It is therefore live now ? |
Thanks @bedroesb , I saw the tool assembly online :) ! |
Thanks for responding! |
Hi,
This is a first version of a plant phenomics assembly page, made thanks to the contributors presenting the different tools.
I would like to talk about it at IPPS next week.
Feel free to edit or comment,
Cheers
Erwan