Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xgit.Repository.WorkingTree.dir_cache/1 output is potentially large. #88

Open
scouten opened this issue Aug 16, 2019 · 0 comments
Open

Xgit.Repository.WorkingTree.dir_cache/1 output is potentially large. #88

scouten opened this issue Aug 16, 2019 · 0 comments
Labels

Comments

@scouten
Copy link
Collaborator

@scouten scouten commented Aug 16, 2019

  • Add label: "TO DO"
  • Add label: "good first issue" or "help wanted" if appropriate
  • Add link to this issue in a comment near the TO DO comment

Describe What Is Incomplete
The function Xgit.Repository.WorkingTree.dir_cache/1 returns a full copy of the Xgit.Core.DirCache struct, complete with all of its entries. That's fine for a small repo, but risky for a potentially large repo.

Definition of Done
Think through how to pass a snapshot of the DirCache struct without overwhelming the VM message-passing mechanism. (Consider a repo with many thousands of files in the index.)

@scouten scouten added the help wanted label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.