Add exception_log_filter option to server
#462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
approved these changes
Nov 7, 2025
sleipnir
reviewed
Nov 7, 2025
Collaborator
sleipnir
left a comment
sleipnir
left a comment
There was a problem hiding this comment.
I only have one question: is it possible to avoid that raise? Other than that, it's okay for me.
Collaborator
|
@ollien we launch https://hex.pm/packages/grpc/0.11.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
This PR adds the ability to filter which exceptions flow through the
ReportExceptionflow. Users can pass a module/function pair to the supervisor, which decides whether or not each exception should be logged. Of course, this allows them to filter on gRPC status codes, too, by simply pattern matching on%GRPC.RPCError{status: status}.I'm certainly open to adjustments here!