Require new pool tests

[josevalim]

For @elixir-lang/ecto-adapters,

• MySQL
• Postgres
• MSSQL
• SQLite3
• Mongo

Just do this: 16f27f6#diff-2c5b8dbebddda6206ddb2951ce5b1bc8R9

[jazzyb]

SQLite: jazzyb/sqlite_ecto@9e9bf3d

[mobileoverlord]

MSSQL: livehelpnow/tds_ecto@9b19c28

[michalmuskala]

Mongo: elixir-mongo/mongodb_ecto@7f44dbb

Also I had to change how I handle pools after changes in Mongo.Adapters.SQL, I noticed one thing that worries me. In start_link we are using pool that can be provided in options, but then in query always the default one is used. Wouldn't this cause issues?
start_link: https://github.com/elixir-lang/ecto/blob/master/lib/ecto/adapters/sql.ex#L355-363
query: https://github.com/elixir-lang/ecto/blob/master/lib/ecto/adapters/sql.ex#L180

[josevalim]

Michal, btw, you don't need to use the Ecto.Adapters.SQL.Sandbox pool. Just
keep size as 1.

It won't cause issues because the idea is that if you are using custom
pools, you will override pool too.

José Valimwww.plataformatec.com.br
http://www.plataformatec.com.br/Founder and Director of R&D

On Wed, Jul 1, 2015 at 9:07 PM, Michał Muskała notifications@github.com
wrote:

Mongo: elixir-mongo/mongodb_ecto@7f44dbb
elixir-mongo/mongodb_ecto@7f44dbb

Also I had to change how I handle pools after changes in
Mongo.Adapters.SQL, I noticed one thing that worries me. In start_link we
are using pool that can be provided in options, but then in query always
the default one is used. Wouldn't this cause issues?
start_link:
https://github.com/elixir-lang/ecto/blob/master/lib/ecto/adapters/sql.ex#L355-363
query:
https://github.com/elixir-lang/ecto/blob/master/lib/ecto/adapters/sql.ex#L180

—
Reply to this email directly or view it on GitHub
#732 (comment).

[michalmuskala]

I reverted the change with the sandbox pool elixir-mongo/mongodb_ecto@ac58a65

[josevalim]

@michalmuskala I also see that you are defining a new pool just because of those tests, I will try to change it so it is not required.

[josevalim]

@michalmuskala i have pushed a commit to master so you no longer need to define a pool only for those tests, they all use test repo now!

[michalmuskala]

I updated the tests: elixir-mongo/mongodb_ecto@f6da6ff