Skip to content

Fix unregistration crash #10326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Sep 13, 2020
Merged

Fix unregistration crash #10326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/elixir/lib/registry.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,8 @@ defmodule Registry do
end

@doc false
def unregister_name({registry, key}) do
unregister(registry, key)
end
def unregister_name({registry, key}), do: unregister(registry, key)
def unregister_name({registry, key, _value}), do: unregister(registry, key)

## Registry API

Expand Down
7 changes: 7 additions & 0 deletions lib/elixir/test/elixir/registry_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,6 +863,13 @@ defmodule RegistryTest do
end
end

test "unregistration on crash with {registry, key, value} via tuple", %{registry: registry} do
name = {:via, Registry, {registry, :name, :value}}
spec = %{id: :foo, start: {Agent, :start_link, [fn -> raise "some error" end, [name: name]]}}
assert {:error, {error, _childspec}} = start_supervised(spec)
assert {%RuntimeError{message: "some error"}, _stacktrace} = error
end

defp register_task(registry, key, value) do
parent = self()

Expand Down