Include cwd in compiler cache key #12462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, moving or copying a directory would not recompile beam files despite the fact their :source absolute path is obsolete. This could create issues with ex_doc.
sabiwara
commented
Mar 12, 2023
|
|
||
| File.touch!("_build/dev/lib/sample/.mix/compile.elixir", @old_time) | ||
|
|
||
| Code.put_compiler_option(:ignore_module_conflict, true) |
Contributor
Author
There was a problem hiding this comment.
I struggled to test this, I have no clear idea if my strategy is good.
Without this I would be getting:
warning: redefining module A (current version loaded from /Users/sabiwara/.../elixir/lib/mix/tmp/Mix.Tasks.Compile.ElixirTest/test recompiles project if working directory changed/_build/dev/lib/sample/ebin/Elixir.A.beam)
lib/a.ex:1: A
Even using purge([A, B]) didn't remove this warning, my mix / :code knowledge is not enough here.
Member
There was a problem hiding this comment.
Honestly, I don’t think a test is necessary. We already test the cache and recompilation elsewhere, which are the important bits.
Contributor
Author
There was a problem hiding this comment.
Got it, will remove the test.
At least it got me confident that the fix was working as expected 🙂
Member
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, moving or copying a directory would not recompile beam files despite the fact their
:sourceabsolute path is obsolete. This could create issues withex_docwhen generating links.