From 4d8af51c20d4ebe68ce436cbbd4defdf99a085a4 Mon Sep 17 00:00:00 2001 From: Eksperimental Date: Fri, 9 May 2025 13:13:36 -0500 Subject: [PATCH 1/2] Improve guard name in recently deprecated Node.start/2-3 `opts` is confusing when the original arg name was `type`. Additional add guards for `tick_time`. --- lib/elixir/lib/node.ex | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/elixir/lib/node.ex b/lib/elixir/lib/node.ex index c81c745c03b..cbfb6df2bd3 100644 --- a/lib/elixir/lib/node.ex +++ b/lib/elixir/lib/node.ex @@ -78,13 +78,14 @@ defmodule Node do end # TODO: Deprecate me on Elixir v1.23 - def start(name, opts) when is_atom(opts) do - :net_kernel.start([name, opts, 15000]) + def start(name, type) when is_atom(type) do + :net_kernel.start([name, type, 15_000]) end # TODO: Deprecate me on Elixir v1.23 @doc false - def start(name, type, tick_time) do + def start(name, type, tick_time) + when is_atom(type) and is_integer(tick_time) and tick_time > 0 do :net_kernel.start([name, type, tick_time]) end From 2e1a25574563b0e4039b1757741cbd4fe6928a67 Mon Sep 17 00:00:00 2001 From: Eksperimental Date: Fri, 9 May 2025 14:32:50 -0500 Subject: [PATCH 2/2] Update lib/elixir/lib/node.ex MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: José Valim --- lib/elixir/lib/node.ex | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/elixir/lib/node.ex b/lib/elixir/lib/node.ex index cbfb6df2bd3..64df49d28a0 100644 --- a/lib/elixir/lib/node.ex +++ b/lib/elixir/lib/node.ex @@ -84,8 +84,7 @@ defmodule Node do # TODO: Deprecate me on Elixir v1.23 @doc false - def start(name, type, tick_time) - when is_atom(type) and is_integer(tick_time) and tick_time > 0 do + def start(name, type, tick_time) do :net_kernel.start([name, type, tick_time]) end