Skip to content

Improve arg name in recently deprecated Node.start/2-3 #14482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2025
Merged

Improve arg name in recently deprecated Node.start/2-3 #14482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d8af51
Improve guard name in recently deprecated Node.start/2-3
eksperimental May 9, 2025
2e1a255
Update lib/elixir/lib/node.ex
eksperimental May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/elixir/lib/node.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ defmodule Node do
end

# TODO: Deprecate me on Elixir v1.23
def start(name, opts) when is_atom(opts) do
:net_kernel.start([name, opts, 15000])
def start(name, type) when is_atom(type) do
:net_kernel.start([name, type, 15_000])
end

# TODO: Deprecate me on Elixir v1.23
Expand Down
Loading