Fix issues with dialyzer infinite loop #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauleth
reviewed
Jul 26, 2018
| true <- unquote(guard_date) do | ||
| {year, month, day} = unquote(read_date) | ||
|
|
||
| with {:ok, date} <- new(year, month, day, Calendar.ISO) do |
There was a problem hiding this comment.
Why not squash it into single with like:
with unquote(match_date) <- string,
true <- unquote(guard_date),
{year, month, day} = unquote(read_date),
{:ok, date} <- new(year, month, day, Calendar.ISO) do
There was a problem hiding this comment.
Because they have different elses.
This was referenced Jul 26, 2018
fertapric
reviewed
Jul 26, 2018
lib/elixir/lib/calendar/date.ex
Outdated
| {:error, :invalid_format} | ||
| [match_date, guard_date, read_date] = Calendar.ISO.__match_date__() | ||
|
|
||
| def raw_from_iso8601(string, calendar) do |
There was a problem hiding this comment.
I think this should be a private function defp
|
❤️ 💚 💙 💛 💜 |
josevalim
pushed a commit
that referenced
this pull request
Jul 26, 2018
Signed-off-by: José Valim <jose.valim@plataformatec.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7989