Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IEx.Server.run/1 #8395

Merged
merged 13 commits into from Nov 17, 2018
Merged

Introduce IEx.Server.run/1 #8395

merged 13 commits into from Nov 17, 2018

Conversation

josevalim
Copy link
Member

Since now there may be multiple servers running,
we also introduced IEx.Broker to negociate pry
requests across multiple sessions.

Shell sessions though are tracked separately from
the remaining ones, as we delegate the shell control
to Erlang's user_drv.

Closes #8203.

Since now there may be multiple servers running,
we also introduced IEx.Broker to negociate pry
requests across multiple sessions.

Shell sessions though are tracked separately from
the remaining ones, as we delegate the shell control
to Erlang's user_drv.
{task, evaluator}
end

defp pry_request(how_many) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty beautiful solution

:ok ->
:ok
case IEx.Broker.take_over(request, [evaluator: self()] ++ opts) do
{:ok, server, leader} ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: group_leader?

@josevalim josevalim merged commit d1e3e4d into master Nov 17, 2018
@josevalim
Copy link
Member Author

❤️ 💚 💙 💛 💜

@josevalim josevalim deleted the jv-iex-broker branch November 17, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants