Fix incorrect id escaping in sidebar #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using triple curly braces causes handlebars to render html and thus also escaped characters fine. This is not an issue, because after converting the docs text with earmark and matching for headings, they are run through HTML.strip_tags/1, ensuring that there are no actual html tags in them.
Member
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #1010 when merged.
Using triple curly braces causes handlebars to render HTML and thus also escaped characters fine. This should not be an issue, because after converting the docs text with earmark and matching for
h2headings, the id's are run throughHTML.strip_tags/1, ensuring that there are no actual html tags in them.The escaping of characters (e.g.
<to<) is done by earmark, an alternative approach would be to re-unencode all escaped characters for the id's, but sinceHTML.strip_tags/1is used anyways, there is no additional security benefit.